Implement the Notification `timestamp` property

content/child/notifications/notification_data_conversions.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/child/notifications/notification_data_conversions.h"
 
 #include "base/strings/utf_string_conversions.h"
+#include "base/time/time.h"
 #include "third_party/WebKit/public/platform/WebString.h"
 #include "third_party/WebKit/public/platform/WebURL.h"
 #include "third_party/WebKit/public/platform/WebVector.h"
 #include "third_party/WebKit/public/platform/modules/notifications/WebNotificationAction.h"
 
 using blink::WebNotificationData;
 
 namespace content {
 
 PlatformNotificationData ToPlatformNotificationData(
@@ skipping 15 matching lines @@
           PlatformNotificationData::DIRECTION_AUTO;
       break;
   }
 
   platform_data.lang = base::UTF16ToUTF8(base::StringPiece16(web_data.lang));
   platform_data.body = web_data.body;
   platform_data.tag = base::UTF16ToUTF8(base::StringPiece16(web_data.tag));
   platform_data.icon = GURL(web_data.icon.string());
   platform_data.vibration_pattern.assign(web_data.vibrate.begin(),
                                          web_data.vibrate.end());
+  platform_data.timestamp = base::Time::FromJsTime(web_data.timestamp);

[johnme, 2015/10/20 17:12:21]

If JS passes MAX_ULL, it'll overflow base::Time, since:
a) base::Time uses an earlier epoch (1601)
b) base::Time is signed so has half the range
It looks like operator+ handles that sensibly, but it won't round-trip to the
same value, so please add a test.

[Peter Beverloo, 2016/01/28 17:18:29]

Done.

   platform_data.silent = web_data.silent;
   platform_data.require_interaction = web_data.requireInteraction;
   platform_data.data.assign(web_data.data.begin(), web_data.data.end());
   platform_data.actions.resize(web_data.actions.size());
   for (size_t i = 0; i < web_data.actions.size(); ++i) {
     platform_data.actions[i].action =
         base::UTF16ToUTF8(base::StringPiece16(web_data.actions[i].action));
     platform_data.actions[i].title = web_data.actions[i].title;
   }
 
@@ skipping 15 matching lines @@
     case PlatformNotificationData::DIRECTION_AUTO:
       web_data.direction = WebNotificationData::DirectionAuto;
       break;
   }
 
   web_data.lang = blink::WebString::fromUTF8(platform_data.lang);
   web_data.body = platform_data.body;
   web_data.tag = blink::WebString::fromUTF8(platform_data.tag);
   web_data.icon = blink::WebURL(platform_data.icon);
   web_data.vibrate = platform_data.vibration_pattern;
+  web_data.timestamp = platform_data.timestamp.ToJsTime();

[johnme, 2015/10/20 17:12:21]

I don't think underflow is possible, and I think zero will round-trip correctly,
but perhaps add a test for the latter anyway?

[Peter Beverloo, 2016/01/28 17:18:29]

Done.

   web_data.silent = platform_data.silent;
   web_data.requireInteraction = platform_data.require_interaction;
   web_data.data = platform_data.data;
   blink::WebVector<blink::WebNotificationAction> resized(
       platform_data.actions.size());
   web_data.actions.swap(resized);
   for (size_t i = 0; i < platform_data.actions.size(); ++i) {
     web_data.actions[i].action =
         blink::WebString::fromUTF8(platform_data.actions[i].action);
     web_data.actions[i].title = platform_data.actions[i].title;
   }
 
   return web_data;
 }
 
 }  // namespace content