Close crashed incognito-mode app's shell window.

Close crashed incognito-mode app's shell window.

ExtensionService is shared between off-the-record and original profiles
(see ExtensionSystemImpl) and notifies unload events always from
the original profile. ShellWindow should therefore observe the original profile as well.

BUG=281675
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247976

[kinaba, 2014-01-30 06:37:36]

yoz: could you take a look? thanks!

[Yoyo Zhou, 2014-01-30 08:54:25]

https://codereview.chromium.org/138843006/diff/20001/apps/shell_window.cc
File apps/shell_window.cc (right):

https://codereview.chromium.org/138843006/diff/20001/apps/shell_window.cc#new...
apps/shell_window.cc:211: content::NotificationService::AllSources());
Use profile_->GetOriginalProfile instead. Then you don't need to change line
746.

[kinaba, 2014-01-30 10:43:21]

https://codereview.chromium.org/138843006/diff/20001/apps/shell_window.cc
File apps/shell_window.cc (right):

https://codereview.chromium.org/138843006/diff/20001/apps/shell_window.cc#new...
apps/shell_window.cc:211: content::NotificationService::AllSources());
On 2014/01/30 08:54:25, Yoyo Zhou wrote:
> Use profile_->GetOriginalProfile instead. Then you don't need to change line
> 746.

Good point. Thanks. Done.

[Yoyo Zhou, 2014-01-30 14:45:14]

lgtm

[commit-bot: I haz the power, 2014-01-30 14:45:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinaba@chromium.org/138843006/40001

[commit-bot: I haz the power, 2014-01-30 17:27:24]

Change committed as 247976

[commit-bot: I haz the power, 2014-01-30 17:27:29]

CQ bit was unchecked on CL. Ignoring.