Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 138843003: Eliminate separate boolean tracking socket writeability in (Closed)

Created:
6 years, 11 months ago by ramant (doing other things)
Modified:
6 years, 11 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Eliminate separate boolean tracking socket writeability in QuicConnection; query the writer instead. This CL tries to minimize behavior changes, so no actual bugfixes. Connection will now check writer's status instead of its local flag, so it will refuse to write sooner. Merge internal change: 59603011 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -137 lines) Patch
M net/quic/quic_connection.h View 6 chunks +6 lines, -14 lines 0 comments Download
M net/quic/quic_connection.cc View 13 chunks +39 lines, -48 lines 0 comments Download
M net/quic/quic_connection_test.cc View 24 chunks +63 lines, -59 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.h View 4 chunks +4 lines, -5 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.cc View 2 chunks +6 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
6 years, 11 months ago (2014-01-15 02:17:53 UTC) #1
Ryan Hamilton
6 years, 11 months ago (2014-01-15 05:24:20 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698