Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 138843002: Roll fontconfig to 2.11.0 and reenable poppler on mac (Closed)

Created:
6 years, 11 months ago by vandebo (ex-Chrome)
Modified:
6 years, 11 months ago
Reviewers:
epoger, mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Roll fontconfig to 2.11.0 and reenable poppler on mac Committed: http://code.google.com/p/skia/source/detail?r=13091

Patch Set 1 #

Patch Set 2 : Fixup win build #

Patch Set 3 : support 64bit win too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -191 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M gyp/common_variables.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M gyp/fontconfig.gyp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/fontconfig/config/fc-lang/fclang.h View 15 chunks +186 lines, -183 lines 0 comments Download
M third_party/fontconfig/config/mac/config.h.template View 4 chunks +11 lines, -4 lines 0 comments Download
M third_party/fontconfig/config/mac/fcstdint.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/fontconfig/config/mac/src/fcalias.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/fontconfig/config/mac/src/fcaliastail.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/fontconfig/config/windows/config.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mtklein
lgtm Memory use peaked around 80M. GM seems to be running okay. Still may find ...
6 years, 11 months ago (2014-01-14 22:22:30 UTC) #1
vandebo (ex-Chrome)
On 2014/01/14 22:22:30, mtklein wrote: > lgtm > > Memory use peaked around 80M. GM ...
6 years, 11 months ago (2014-01-14 22:23:53 UTC) #2
vandebo (ex-Chrome)
6 years, 11 months ago (2014-01-15 16:32:37 UTC) #3
epoger
lgtm
6 years, 11 months ago (2014-01-15 16:35:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/vandebo@chromium.org/138843002/190002
6 years, 11 months ago (2014-01-15 16:36:00 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-15 17:24:28 UTC) #6
Message was sent while issue was closed.
Change committed as 13091

Powered by Google App Engine
This is Rietveld 408576698