Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1388423004: Add more dart2js operator tests (Closed)

Created:
5 years, 2 months ago by sra1
Modified:
5 years, 2 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add more dart2js operator tests The test was completely constant folded! Making functions @NoInline() and also obfuscating values to a num/uint31/uint32 value gives better coverage of the internals of the more complex operators. R=asgerf@google.com Committed: https://github.com/dart-lang/sdk/commit/334549af2096500424461bfafe440d40aba7f660

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -6 lines) Patch
M tests/compiler/dart2js_extra/operator_test.dart View 17 chunks +221 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
5 years, 2 months ago (2015-10-15 03:39:27 UTC) #2
asgerf
LGTM
5 years, 2 months ago (2015-10-15 08:54:56 UTC) #4
sra1
5 years, 2 months ago (2015-10-15 18:11:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
334549af2096500424461bfafe440d40aba7f660 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698