Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1388413006: - Adjust test to renamed optional parameter. (Closed)

Created:
5 years, 2 months ago by Ivan Posva
Modified:
5 years, 2 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Adjust test to renamed optional parameter. BUG= Committed: https://github.com/dart-lang/sdk/commit/52bd332576567f9bd73214a81536eed7fec8e100

Patch Set 1 #

Patch Set 2 : Undo remove of "dart:io" import. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M tests/isolate/isolate.status View 1 chunk +2 lines, -1 line 0 comments Download
M tests/isolate/package_map_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Ivan Posva
Fix build. TBR
5 years, 2 months ago (2015-10-12 16:34:32 UTC) #2
Ivan Posva
Committed patchset #2 (id:20001) manually as 52bd332576567f9bd73214a81536eed7fec8e100 (presubmit successful).
5 years, 2 months ago (2015-10-12 16:43:01 UTC) #3
siva
lgtm
5 years, 2 months ago (2015-10-12 16:45:22 UTC) #4
Lasse Reichstein Nielsen
5 years, 2 months ago (2015-10-12 20:03:49 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698