Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: runtime/vm/assembler_mips.cc

Issue 13884017: Adds support for UseDartApi vm test on MIPS. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/assembler_mips.cc
===================================================================
--- runtime/vm/assembler_mips.cc (revision 21386)
+++ runtime/vm/assembler_mips.cc (working copy)
@@ -117,6 +117,45 @@
}
+void Assembler::SubuDetectOverflow(Register rd, Register rs, Register rt,
+ Register ro) {
+ ASSERT(rd != ro);
+ ASSERT(rd != TMP1);
+ ASSERT(ro != TMP1);
+ ASSERT(ro != rs);
+ ASSERT(ro != rt);
+ ASSERT(rs != TMP1);
+ ASSERT(rt != TMP1);
+
+ // This happens with some crankshaft code. Since Subu works fine if
+ // left == right, let's not make that restriction here.
+ if (rs == rt) {
+ mov(rd, ZR);
+ mov(ro, ZR);
+ return;
+ }
+
+ if (rd == rs) {
+ mov(TMP1, rs); // Preserve left.
+ subu(rd, rs, rt); // Left is overwritten.
+ xor_(ro, rd, TMP1); // scratch is original left.
+ xor_(TMP1, TMP1, rs); // scratch is original left.
+ and_(ro, TMP1, ro);
+ } else if (rd == rt) {
+ mov(TMP1, rt); // Preserve right.
+ subu(rd, rs, rt); // Right is overwritten.
+ xor_(ro, rd, rs);
+ xor_(TMP1, rs, TMP1); // Original right.
+ and_(ro, TMP1, ro);
+ } else {
+ subu(rd, rs, rt);
+ xor_(ro, rd, rs);
+ xor_(TMP1, rs, rt);
+ and_(ro, TMP1, ro);
+ }
+}
+
+
void Assembler::LoadObject(Register rd, const Object& object) {
// Smi's and VM heap objects are never relocated; do not use object pool.
if (object.IsSmi()) {

Powered by Google App Engine
This is Rietveld 408576698