Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1388383002: [heap] Unify accounting committed memory across all spaces. (Closed)

Created:
5 years, 2 months ago by Michael Lippautz
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Unify accounting committed memory across all spaces. Untangles committed memory from capacity in a given space and unifies accounting for all spaces. Pre-work for parallel compaction. R=hpayer@chromium.org BUG=chromium:524425 LOG=N Committed: https://crrev.com/465caac813d428feb35ee2209133a4f6f6d396aa Cr-Commit-Position: refs/heads/master@{#31149}

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -44 lines) Patch
M src/heap/spaces.h View 1 11 chunks +36 lines, -33 lines 0 comments Download
M src/heap/spaces.cc View 12 chunks +12 lines, -9 lines 0 comments Download
M test/cctest/test-spaces.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1388383002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1388383002/20001
5 years, 2 months ago (2015-10-07 11:05:49 UTC) #3
Michael Lippautz
PTAL; We already have tests that check against committed memory and they were failing left ...
5 years, 2 months ago (2015-10-07 11:15:08 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-07 11:42:42 UTC) #7
Hannes Payer (out of office)
LGTM https://codereview.chromium.org/1388383002/diff/20001/src/heap/spaces.h File src/heap/spaces.h (right): https://codereview.chromium.org/1388383002/diff/20001/src/heap/spaces.h#newcode928 src/heap/spaces.h:928: // headers. ... i.e., allocatable memory and page ...
5 years, 2 months ago (2015-10-07 11:43:35 UTC) #8
Michael Lippautz
https://codereview.chromium.org/1388383002/diff/20001/src/heap/spaces.h File src/heap/spaces.h (right): https://codereview.chromium.org/1388383002/diff/20001/src/heap/spaces.h#newcode928 src/heap/spaces.h:928: // headers. On 2015/10/07 11:43:35, Hannes Payer wrote: > ...
5 years, 2 months ago (2015-10-07 11:48:09 UTC) #9
Michael Lippautz
https://codereview.chromium.org/1388383002/diff/20001/src/heap/spaces.h File src/heap/spaces.h (right): https://codereview.chromium.org/1388383002/diff/20001/src/heap/spaces.h#newcode928 src/heap/spaces.h:928: // headers. On 2015/10/07 11:43:35, Hannes Payer wrote: > ...
5 years, 2 months ago (2015-10-07 11:48:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1388383002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1388383002/40001
5 years, 2 months ago (2015-10-07 11:48:22 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 2 months ago (2015-10-07 12:11:58 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 12:12:11 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/465caac813d428feb35ee2209133a4f6f6d396aa
Cr-Commit-Position: refs/heads/master@{#31149}

Powered by Google App Engine
This is Rietveld 408576698