chrome/browser/resources/settings/default_browser_page/default_browser_page.html - Issue 1388353003: [MD settings] adding DefaultBrowser settings page

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/default_browser_page/default_browser_page.html

Issue 1388353003: [MD settings] adding DefaultBrowser settings page (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: moved upstream branch to master Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/settings/default_browser_page/default_browser_page.css ('k') | chrome/browser/resources/settings/default_browser_page/default_browser_page.js » ('j') | chrome/browser/resources/settings/default_browser_page/default_browser_page.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">

	2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icon/iron-icon.htm l">

	3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">

	4 <link rel="import" href="chrome://md-settings/i18n_behavior/i18n_behavior.html">

	5

	6 <dom-module id="settings-default-browser-page">

	7 <link rel="import" type="css"

	8 href="chrome://md-settings/settings_page/settings_page.css">

	9 <link rel="import" type="css" href="default_browser_page.css">

	10 <template>

	11 <div>[[message_]]</div>

	12 <template is="dom-if" if="[[showButton_]]">

	13 <paper-button on-tap="onSetDefaultBrowserTap_"

	14 >[[i18n('defaultBroswerMakeDefault')]]</paper-button>

	15 <template is="dom-if" if="[[showError_]]">

	16 <iron-icon icon="error" i18n-values="title:unableToSetDefaultBrowser"
	Dan Beam 2015/10/09 01:41:51 wait, wait does i18n-values work here but i18n-con wait, wait does i18n-values work here but i18n-content="defaultBrowserMakeDefault" wouldn't? dschuyler 2015/10/09 02:20:38 This string isn't present in the pak file yet. So Show quoted text On 2015/10/09 01:41:51, Dan Beam wrote: > wait, wait does i18n-values work here but > i18n-content="defaultBrowserMakeDefault" wouldn't? This string isn't present in the pak file yet. So it failing would not be immediately noticed.
	17 class="error-icon"></iron-icon>

	18 </template>

	19 </template>

	20 </template>

	21 <script src="default_browser_page.js"></script>

	22 </dom-module>

OLD	NEW