Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1704)

Unified Diff: chrome/browser/permissions/permission_context_base.cc

Issue 1388343003: Adds a field trial to control Web API kill switches. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comment Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/permissions/permission_context_base.cc
diff --git a/chrome/browser/permissions/permission_context_base.cc b/chrome/browser/permissions/permission_context_base.cc
index f329b2bbb640a9b6826ee85bac39ff266dbc7528..a6defc68d853d95dbe9521528736af93099b2e9a 100644
--- a/chrome/browser/permissions/permission_context_base.cc
+++ b/chrome/browser/permissions/permission_context_base.cc
@@ -16,10 +16,18 @@
#include "chrome/common/pref_names.h"
#include "components/content_settings/core/browser/host_content_settings_map.h"
#include "components/content_settings/core/browser/website_settings_registry.h"
+#include "components/variations/variations_associated_data.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/web_contents.h"
#include "content/public/common/origin_util.h"
+// API kill switch Finch Trials
raymes 2015/10/13 01:30:18 nit: don't really need this comment now that comme
kcarattini 2015/10/13 03:06:22 Done.
+// static
+const char PermissionContextBase::kApiKillSwitchFieldStudy[] = "ApiKillSwitch";
+// static
+const char PermissionContextBase::kApiKillSwitchFieldParamEnabledValue[] =
+ "enabled";
+
PermissionContextBase::PermissionContextBase(
Profile* profile,
const ContentSettingsType permission_type)
@@ -42,6 +50,15 @@ void PermissionContextBase::RequestPermission(
const BrowserPermissionCallback& callback) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+ // First check if this API has been disabled through Finch.
+ if (IsApiKillSwitchOn()) {
+ // The kill switch is enabled for this API; Block all requests.
+ NotifyPermissionSet(id, requesting_frame.GetOrigin(),
+ web_contents->GetLastCommittedURL().GetOrigin(), callback,
+ false /* persist */, CONTENT_SETTING_BLOCK);
+ return;
+ }
+
DecidePermission(web_contents,
id,
requesting_frame.GetOrigin(),
@@ -53,6 +70,11 @@ void PermissionContextBase::RequestPermission(
ContentSetting PermissionContextBase::GetPermissionStatus(
const GURL& requesting_origin,
const GURL& embedding_origin) const {
+
+ // If the API has been disabled through Finch, block all requests.
+ if (IsApiKillSwitchOn())
+ return CONTENT_SETTING_BLOCK;
+
if (IsRestrictedToSecureOrigins() &&
!content::IsOriginSecure(requesting_origin)) {
return CONTENT_SETTING_BLOCK;
@@ -256,3 +278,11 @@ void PermissionContextBase::UpdateContentSetting(
ContentSettingsPattern::FromURLNoWildcard(embedding_origin),
permission_type_, std::string(), content_setting);
}
+
+bool PermissionContextBase::IsApiKillSwitchOn() const {
+ const std::string param =
+ variations::GetVariationParamValue(kApiKillSwitchFieldStudy,
+ PermissionContextUmaUtil::GetPermissionString(permission_type_));
+
+ return param == kApiKillSwitchFieldParamEnabledValue;
+}

Powered by Google App Engine
This is Rietveld 408576698