Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Unified Diff: remoting/host/it2me/it2me_native_messaging_host.h

Issue 138833009: For C++ readability review. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/host/it2me/it2me_native_messaging_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/it2me/it2me_native_messaging_host.h
diff --git a/remoting/host/it2me/it2me_native_messaging_host.h b/remoting/host/it2me/it2me_native_messaging_host.h
index e0fd8022620f11615cc8708052967e07fbc1490b..1445872616aabd10738b3d8fff564795ef62b065 100644
--- a/remoting/host/it2me/it2me_native_messaging_host.h
+++ b/remoting/host/it2me/it2me_native_messaging_host.h
@@ -21,15 +21,13 @@ namespace remoting {
// Implementation of the native messaging host process.
class It2MeNativeMessagingHost : public It2MeHost::Observer {
public:
- typedef NativeMessagingChannel::SendMessageCallback SendMessageCallback;
-
It2MeNativeMessagingHost(
scoped_refptr<AutoThreadTaskRunner> task_runner,
scoped_ptr<NativeMessagingChannel> channel,
scoped_ptr<It2MeHostFactory> factory);
virtual ~It2MeNativeMessagingHost();
- void Start(const base::Closure& quit_closure);
+ void Start(const base::Closure& quit_closure) const;
// It2MeHost::Observer implementation
virtual void OnClientAuthenticated(const std::string& client_username)
@@ -48,15 +46,15 @@ class It2MeNativeMessagingHost : public It2MeHost::Observer {
// dictionary is pre-filled by ProcessMessage() with the parts of the
// response already known ("id" and "type" fields).
void ProcessHello(const base::DictionaryValue& message,
- scoped_ptr<base::DictionaryValue> response);
+ scoped_ptr<base::DictionaryValue> response) const;
void ProcessConnect(const base::DictionaryValue& message,
scoped_ptr<base::DictionaryValue> response);
void ProcessDisconnect(const base::DictionaryValue& message,
scoped_ptr<base::DictionaryValue> response);
void SendErrorAndExit(scoped_ptr<base::DictionaryValue> response,
- const std::string& description);
+ const std::string& description) const;
- scoped_refptr<AutoThreadTaskRunner> task_runner();
+ scoped_refptr<AutoThreadTaskRunner> task_runner() const;
scoped_ptr<NativeMessagingChannel> channel_;
scoped_ptr<It2MeHostFactory> factory_;
@@ -84,3 +82,4 @@ class It2MeNativeMessagingHost : public It2MeHost::Observer {
} // namespace remoting
#endif // REMOTING_HOST_IT2ME_IT2ME_NATIVE_MESSAGING_HOST_H_
+
nadav 2014/02/20 00:48:47 You should now be able to remove the trailing empt
« no previous file with comments | « no previous file | remoting/host/it2me/it2me_native_messaging_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698