For C++ readability review.

remoting/host/it2me/it2me_native_messaging_host.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_HOST_IT2ME_IT2ME_NATIVE_MESSAGING_HOST_H_
 #define REMOTING_HOST_IT2ME_IT2ME_NATIVE_MESSAGING_HOST_H_
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "remoting/base/auto_thread_task_runner.h"
 #include "remoting/host/it2me/it2me_host.h"
 #include "remoting/host/native_messaging/native_messaging_channel.h"
 
 namespace base {
 class DictionaryValue;
 }  // namespace base
 
 namespace remoting {
 
 // Implementation of the native messaging host process.
 class It2MeNativeMessagingHost : public It2MeHost::Observer {
  public:
   typedef NativeMessagingChannel::SendMessageCallback SendMessageCallback;

[nadav, 2014/02/06 08:23:49]

Why do you need this typedef as part of the class's public interface? It seems
to not be needed by users of this class.

[weitao, 2014/02/19 00:40:03]

No, removed.

On 2014/02/06 08:23:49, nadav wrote:

 
   It2MeNativeMessagingHost(
       scoped_refptr<AutoThreadTaskRunner> task_runner,
       scoped_ptr<NativeMessagingChannel> channel,

[nadav, 2014/02/06 08:23:49]

scoped_ptr is sorta deprecated with the advent of C++11's unique_ptr. Why not
use std::unique_ptr? Is Chromium still not allowing such features?
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Owners...

[weitao, 2014/02/19 00:40:03]

Many of the C++11 features (unique_ptr and shared_ptr in particular) are not
used at all in the chromium project and I do not know the reason. Could it just
be because of the different level of support of the C++11 features on the
different platforms (Windows, Mac, Win, and Android)? 

I am adding Sergey to the reviewer list and see if he can provide some insight.

On 2014/02/06 08:23:49, nadav wrote:

[Sergey Ulanov, 2014/02/19 01:52:52]

We don't use C++11 in chromium yet because not all platforms we need to compile
for support it. Relevant thread in chromium-dev with more details:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/oVTPsijC7d0

       scoped_ptr<It2MeHostFactory> factory);
   virtual ~It2MeNativeMessagingHost();
 
   void Start(const base::Closure& quit_closure);
 
   // It2MeHost::Observer implementation
   virtual void OnClientAuthenticated(const std::string& client_username)
       OVERRIDE;
   virtual void OnStoreAccessCode(const std::string& access_code,
                                  base::TimeDelta access_code_lifetime) OVERRIDE;
@@ skipping 38 matching lines @@
 
   base::WeakPtr<It2MeNativeMessagingHost> weak_ptr_;
   base::WeakPtrFactory<It2MeNativeMessagingHost> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(It2MeNativeMessagingHost);
 };
 
 }  // namespace remoting
 
 #endif  // REMOTING_HOST_IT2ME_IT2ME_NATIVE_MESSAGING_HOST_H_
+