Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 138833004: Uses WeakPtrFactory instead of base::Unretained. (Closed)

Created:
6 years, 10 months ago by Jun Mukai
Modified:
6 years, 10 months ago
Reviewers:
stevenjb, dewittj
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Visibility:
Public.

Description

Uses WeakPtrFactory instead of base::Unretained. Although TrayIME removes the notification, the callback notification delegate may survive due to complicated ref-counted-ness of NotificationDelegate. Anyways WeakPtr would be better here rather than Unretained. BUG=336650 R=stevenjb@chromium.org, dewittj@chromium.org TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248577

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M ash/system/ime/tray_ime.h View 2 chunks +3 lines, -0 lines 0 comments Download
M ash/system/ime/tray_ime.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Jun Mukai
6 years, 10 months ago (2014-02-03 18:10:33 UTC) #1
stevenjb
lgtm
6 years, 10 months ago (2014-02-03 18:11:36 UTC) #2
dewittj
Did you find a reproducible way to cause the crash, or is this speculative? lgtm
6 years, 10 months ago (2014-02-03 18:11:58 UTC) #3
Jun Mukai
On 2014/02/03 18:11:58, dewittj wrote: > Did you find a reproducible way to cause the ...
6 years, 10 months ago (2014-02-03 18:49:05 UTC) #4
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 10 months ago (2014-02-03 18:49:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/138833004/1
6 years, 10 months ago (2014-02-03 18:50:30 UTC) #6
commit-bot: I haz the power
Change committed as 248577
6 years, 10 months ago (2014-02-03 21:27:27 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-03 21:27:32 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-03 21:27:36 UTC) #9
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698