Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 1388293002: Notify WebContentsObservers of user interactions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding histogram. Addressing reviewer feedback Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_impl.cc
diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc
index c89bba6c56f4cf3c9c60626f85bef724b0c5b06e..a6a97eb8eecf451da83f760f8538569cdfe5f46b 100644
--- a/content/browser/renderer_host/render_widget_host_impl.cc
+++ b/content/browser/renderer_host/render_widget_host_impl.cc
@@ -1445,6 +1445,12 @@ void RenderWidgetHostImpl::RendererIsResponsive() {
}
}
+void RenderWidgetHostImpl::OnUserInteraction(
+ const blink::WebInputEvent::Type type) {
+ if (delegate_)
+ delegate_->OnUserInteraction(type);
nasko 2015/10/28 17:36:12 Why have a separate method for a two line body? Ca
dominickn 2015/10/29 00:03:19 Done.
+}
+
void RenderWidgetHostImpl::ClearDisplayedGraphics() {
NotifyNewContentRenderingTimeoutForTesting();
if (view_)
@@ -1858,6 +1864,12 @@ InputEventAckState RenderWidgetHostImpl::FilterInputEvent(
OnUserGesture();
}
+ if (event.type == WebInputEvent::MouseDown ||
+ event.type == WebInputEvent::GestureTapDown ||
+ event.type == WebInputEvent::RawKeyDown) {
+ OnUserInteraction(event.type);
+ }
+
return view_ ? view_->FilterInputEvent(event)
: INPUT_EVENT_ACK_STATE_NOT_CONSUMED;
}

Powered by Google App Engine
This is Rietveld 408576698