content/browser/renderer_host/render_widget_host_impl.cc - Issue 1388293002: Notify WebContentsObservers of user interactions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 1388293002: Notify WebContentsObservers of user interactions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing reviewer feedback Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_impl.cc

diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc

index c89bba6c56f4cf3c9c60626f85bef724b0c5b06e..58a2aeab1a3aa59f386abaa7eb17337254a39c14 100644

--- a/content/browser/renderer_host/render_widget_host_impl.cc

+++ b/content/browser/renderer_host/render_widget_host_impl.cc

@@ -1858,6 +1858,13 @@ InputEventAckState RenderWidgetHostImpl::FilterInputEvent(

OnUserGesture();

}

+ if (event.type == WebInputEvent::MouseDown ||

+ event.type == WebInputEvent::GestureTapDown ||

+ event.type == WebInputEvent::RawKeyDown ||

+ event.type == WebInputEvent::MouseWheel) {

+ OnUserInteraction(event.type);

+ }

return view_ ? view_->FilterInputEvent(event)

: INPUT_EVENT_ACK_STATE_NOT_CONSUMED;

}