chrome/browser/engagement/site_engagement_metrics.h - Issue 1388293002: Notify WebContentsObservers of user interactions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/engagement/site_engagement_metrics.h

Issue 1388293002: Notify WebContentsObservers of user interactions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing nits Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/engagement/site_engagement_metrics.h

diff --git a/chrome/browser/engagement/site_engagement_metrics.h b/chrome/browser/engagement/site_engagement_metrics.h

index d07cdaa2de32ec63fcaafe4b3a8f4242d4ad905d..143ec5e6daa8a697699c5de343a746bb23404394 100644

--- a/chrome/browser/engagement/site_engagement_metrics.h

+++ b/chrome/browser/engagement/site_engagement_metrics.h

@@ -20,6 +20,7 @@ class SiteEngagementMetrics {

ENGAGEMENT_NAVIGATION,

ENGAGEMENT_KEYPRESS,

ENGAGEMENT_MOUSE,

+ ENGAGEMENT_TOUCH_GESTURE,

ENGAGEMENT_LAST,

};

@@ -35,7 +36,7 @@ class SiteEngagementMetrics {

private:

FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceTest, CheckHistograms);

- FRIEND_TEST_ALL_PREFIXES(SiteEngagementServiceBrowserTest,

+ FRIEND_TEST_ALL_PREFIXES(SiteEngagementHelperTest,

MixedInputEngagementAccumulation);

static const char kTotalEngagementHistogram[];

static const char kTotalOriginsHistogram[];