Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(882)

Side by Side Diff: content/browser/renderer_host/render_widget_host_impl.h

Issue 1388293002: Notify WebContentsObservers of user interactions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing reviewer feedback Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_
7 7
8 #include <list> 8 #include <list>
9 #include <map> 9 #include <map>
10 #include <string> 10 #include <string>
(...skipping 500 matching lines...) Expand 10 before | Expand all | Expand 10 after
511 // its delegate. 511 // its delegate.
512 512
513 // Called when a mousewheel event was not processed by the renderer. 513 // Called when a mousewheel event was not processed by the renderer.
514 virtual void UnhandledWheelEvent(const blink::WebMouseWheelEvent& event) {} 514 virtual void UnhandledWheelEvent(const blink::WebMouseWheelEvent& event) {}
515 515
516 // Notification that the user has made some kind of input that could 516 // Notification that the user has made some kind of input that could
517 // perform an action. The gestures that count are 1) any mouse down 517 // perform an action. The gestures that count are 1) any mouse down
518 // event and 2) enter or space key presses. 518 // event and 2) enter or space key presses.
519 virtual void OnUserGesture() {} 519 virtual void OnUserGesture() {}
520 520
521 // Notification that the user has made some kind of direct input with the
522 // page. Direct input includes 1) any mouse down event; 2) any mouse wheel
523 // event; 3) any raw key down event; and 4) any gesture tap event.
524 virtual void OnUserInteraction(const blink::WebInputEvent::Type type) {}
jdduke (slow) 2015/10/26 16:02:53 Should we keep the naming consistent, e.g., OnUser
dominickn 2015/10/27 07:03:57 From nasko's comment, I've removed the Start prefi
525
521 // Callbacks for notification when the renderer becomes unresponsive to user 526 // Callbacks for notification when the renderer becomes unresponsive to user
522 // input events, and subsequently responsive again. 527 // input events, and subsequently responsive again.
523 virtual void NotifyRendererUnresponsive() {} 528 virtual void NotifyRendererUnresponsive() {}
524 virtual void NotifyRendererResponsive() {} 529 virtual void NotifyRendererResponsive() {}
525 530
526 // Callback for notification that we failed to receive any rendered graphics 531 // Callback for notification that we failed to receive any rendered graphics
527 // from a newly loaded page. Used for testing. 532 // from a newly loaded page. Used for testing.
528 virtual void NotifyNewContentRenderingTimeoutForTesting() {} 533 virtual void NotifyNewContentRenderingTimeoutForTesting() {}
529 534
530 // Called when auto-resize resulted in the renderer size changing. 535 // Called when auto-resize resulted in the renderer size changing.
(...skipping 313 matching lines...) Expand 10 before | Expand all | Expand 10 after
844 base::TimeDelta new_content_rendering_delay_; 849 base::TimeDelta new_content_rendering_delay_;
845 850
846 base::WeakPtrFactory<RenderWidgetHostImpl> weak_factory_; 851 base::WeakPtrFactory<RenderWidgetHostImpl> weak_factory_;
847 852
848 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostImpl); 853 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostImpl);
849 }; 854 };
850 855
851 } // namespace content 856 } // namespace content
852 857
853 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_ 858 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698