content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 1388283002: Fix OSK flickering issue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 1388283002: Fix OSK flickering issue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: switched to ime guard approach Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index 69d11cf978e8029adf93e805b3e2ad632d3cddc1..c13903e5e32f71154981e392b48ae1add96381c3 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -2473,8 +2473,9 @@ public class ContentViewCore implements

boolean focusedNodeIsPassword = (textInputType == TextInputType.PASSWORD);

if (!focusedNodeEditable) hidePastePopup();

+ mImeAdapter.attach(nativeImeAdapterAndroid);

mImeAdapter.updateKeyboardVisibility(

- nativeImeAdapterAndroid, textInputType, textInputFlags, showImeIfNeeded);

+ textInputType, textInputFlags, showImeIfNeeded);

if (mInputConnection != null) {

mInputConnection.updateState(text, selectionStart, selectionEnd, compositionStart,

« no previous file with comments | « no previous file | content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java » ('j') | content/renderer/render_widget.h » ('J')