Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: content/renderer/render_view_browsertest.cc

Issue 1388283002: Fix OSK flickering issue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix more tests except for contextualsearchmanagertests Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_browsertest.cc
diff --git a/content/renderer/render_view_browsertest.cc b/content/renderer/render_view_browsertest.cc
index a7e700ff38e465f65fc0f0d6dd2be7bb11333e6b..599f97416a0cfd3fcbdf146edae40934996f1249 100644
--- a/content/renderer/render_view_browsertest.cc
+++ b/content/renderer/render_view_browsertest.cc
@@ -981,6 +981,7 @@ TEST_F(RenderViewImplTest, OnImeTypeChanged) {
// to activate IMEs.
view()->UpdateTextInputState(
RenderWidget::NO_SHOW_IME, RenderWidget::FROM_NON_IME);
+ ProcessPendingMessages();
const IPC::Message* msg = render_thread_->sink().GetMessageAt(0);
EXPECT_TRUE(msg != NULL);
EXPECT_EQ(ViewHostMsg_TextInputStateChanged::ID, msg->type());
@@ -1003,6 +1004,7 @@ TEST_F(RenderViewImplTest, OnImeTypeChanged) {
// to de-activate IMEs.
view()->UpdateTextInputState(
RenderWidget::NO_SHOW_IME, RenderWidget::FROM_NON_IME);
+ ProcessPendingMessages();
msg = render_thread_->sink().GetMessageAt(0);
EXPECT_TRUE(msg != NULL);
EXPECT_EQ(ViewHostMsg_TextInputStateChanged::ID, msg->type());
@@ -1027,6 +1029,7 @@ TEST_F(RenderViewImplTest, OnImeTypeChanged) {
// message to activate IMEs.
view()->UpdateTextInputState(
RenderWidget::NO_SHOW_IME, RenderWidget::FROM_NON_IME);
+ ProcessPendingMessages();
const IPC::Message* msg = render_thread_->sink().GetMessageAt(0);
EXPECT_TRUE(msg != NULL);
EXPECT_EQ(ViewHostMsg_TextInputStateChanged::ID, msg->type());
@@ -1959,6 +1962,7 @@ TEST_F(RenderViewImplTest, MessageOrderInDidChangeSelection) {
view()->handling_input_event_ = true;
ExecuteJavaScriptForTests("document.getElementById('test').focus();");
+ ProcessPendingMessages();
bool is_input_type_called = false;
bool is_selection_called = false;

Powered by Google App Engine
This is Rietveld 408576698