Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1388273002: Reimplement NV21ToARGB to allow different color matrix. (Closed)

Created:
5 years, 2 months ago by fbarchard1
Modified:
5 years, 2 months ago
Reviewers:
harryjin
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Reimplement NV21ToARGB to allow different color matrix. Low level for NV21ToARGB written to accept yuv matrix used by other YUV to ARGB functions. Previously NV21 was implemented for Windows using NV12 with a different matrix that swapped U and V. But the Arm version of the low level does not allow the matrix U and V contributions to be swapped. Using a new low level function that reads NV21 and uses the same yuvconstants as other YUV conversion functions allows an Arm port of this function. TBR=harryjin@google.com BUG=libyuv:500 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/914a9856c7e6cab17f9d923119e043947f5aa58c

Patch Set 1 #

Patch Set 2 : gcc version of NV21 to ARGB #

Patch Set 3 : include scale_row.h for scaling macros #

Unified diffs Side-by-side diffs Delta from patch set Stats (+338 lines, -87 lines) Patch
M include/libyuv/planar_functions.h View 1 chunk +0 lines, -7 lines 0 comments Download
M include/libyuv/row.h View 8 chunks +38 lines, -0 lines 0 comments Download
M include/libyuv/scale_row.h View 3 chunks +20 lines, -6 lines 0 comments Download
M source/convert_argb.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M source/planar_functions.cc View 1 chunk +0 lines, -58 lines 0 comments Download
M source/row_any.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M source/row_common.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M source/row_gcc.cc View 1 5 chunks +81 lines, -1 line 0 comments Download
M source/row_neon.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download
M source/row_neon64.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download
M source/row_win.cc View 5 chunks +95 lines, -0 lines 0 comments Download
M source/scale_gcc.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M unit_test/convert_test.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
fbarchard
win64 llvm version NV12ToARGB_Any (582 ms) NV21ToARGB_Invert (550 ms) NV21ToARGB_Unaligned (515 ms) NV12ToARGB_Unaligned (502 ms) ...
5 years, 2 months ago (2015-10-07 03:34:32 UTC) #4
fbarchard1
Committed patchset #3 (id:40001) manually as 914a9856c7e6cab17f9d923119e043947f5aa58c (presubmit successful).
5 years, 2 months ago (2015-10-07 03:34:49 UTC) #5
harryjin
5 years, 2 months ago (2015-10-07 05:30:48 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698