Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1388133002: Revert of Changed scavenge GC to collect unmodified references (Closed)

Created:
5 years, 2 months ago by Michael Achenbach
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Changed scavenge GC to collect unmodified references (patchset #9 id:160001 of https://codereview.chromium.org/1358703003/ ) Reason for revert: [Sheriff] Speculative revert due to crbug.com/539814 Original issue's description: > Changed scavenge GC to collect unmodified references > > Added a scavenge GC pass that collects unmodified references instead of > processing object groups. This mode can be controlled by setting > FLAG_scavenge_remove_unmodified_objects. By default this is turned off. > Also, modified a test case to suit the handle the new GC pass. > > BUG=v8:4421 > LOG=N > > Committed: https://crrev.com/6254019238a853c9f3c09d615ba153043f6957c7 > Cr-Commit-Position: refs/heads/master@{#31102} TBR=jochen@chromium.org,rmcilroy@chromium.org,mythria@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4421, chromium:539814 Committed: https://crrev.com/2e1dbae08b8fcec94068bb5eb85fae03e73e84d2 Cr-Commit-Position: refs/heads/master@{#31130}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -170 lines) Patch
M src/flag-definitions.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/global-handles.h View 2 chunks +1 line, -14 lines 0 comments Download
M src/global-handles.cc View 10 chunks +12 lines, -104 lines 0 comments Download
M src/heap/heap.cc View 6 chunks +11 lines, -46 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Achenbach
Created Revert of Changed scavenge GC to collect unmodified references
5 years, 2 months ago (2015-10-06 16:54:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1388133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1388133002/1
5 years, 2 months ago (2015-10-06 16:55:40 UTC) #3
commit-bot: I haz the power
Failed to apply patch for test/cctest/test-api.cc: While running git apply --index -3 -p1; error: patch ...
5 years, 2 months ago (2015-10-06 16:56:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1388133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1388133002/1
5 years, 2 months ago (2015-10-06 17:39:32 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-06 17:39:46 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 17:39:59 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e1dbae08b8fcec94068bb5eb85fae03e73e84d2
Cr-Commit-Position: refs/heads/master@{#31130}

Powered by Google App Engine
This is Rietveld 408576698