chrome/browser/resources/chromeos/login/screen_container.html - Issue 13881017: Extract common HTML from oobe.html/login.html.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/chromeos/login/screen_container.html

Issue 13881017: Extract common HTML from oobe.html/login.html. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <div id="background" class="background-initial"></div>

	2 <include src="version.html">

	3 <div id="outer-container">

	4 <div id="oobe" class="faded">

	5 <div id="inner-container" class="down">

	6 <div id="step-logo" hidden>

	7 <img src="chrome://theme/IDR_PRODUCT_LOGO" alt="">
	Nikita (slow) 2013/04/18 09:29:40 nit: alt attribute could be dropped nit: alt attribute could be dropped dzhioev (left Google) 2013/04/18 09:33:30 No, alt attribute is required for img in html5. Bu Show quoted text On 2013/04/18 09:29:40, Nikita Kostylev wrote: > nit: alt attribute could be dropped No, alt attribute is required for img in html5. But you can simply use empty attribute <img alt ... > instead of <img alt="">. Nikita (slow) 2013/04/18 09:36:55 Thanks for clarification. Show quoted text On 2013/04/18 09:33:30, dzhioev wrote: > On 2013/04/18 09:29:40, Nikita Kostylev wrote: > > nit: alt attribute could be dropped > No, alt attribute is required for img in html5. But you can simply use empty > attribute <img alt ... > instead of <img alt="">. Thanks for clarification. dconnelly 2013/04/18 12:50:47 Done. Show quoted text On 2013/04/18 09:33:30, dzhioev wrote: > On 2013/04/18 09:29:40, Nikita Kostylev wrote: > > nit: alt attribute could be dropped > No, alt attribute is required for img in html5. But you can simply use empty > attribute <img alt ... > instead of <img alt="">. Done.
	8 <div id="header-sections">

	9 </div>

	10 </div>

	11 <include src="oobe_screens.html">

	12 </div>

	13 <div id="progress-dots" class="down"></div>

	14 </div>

	15 </div>

	16 <div id="bubble" class="bubble faded" hidden></div>

	17 <include src="header_bar.html">

	18 <include src="user_pod_template.html">

OLD	NEW

« no previous file with comments | « chrome/browser/resources/chromeos/login/oobe_screens.html ('k') | no next file » | no next file with comments »