Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 13881010: Move Layout unit test into webkit_unit_tests. (Closed)

Created:
7 years, 8 months ago by tfarina
Modified:
7 years, 8 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move Layout unit test into webkit_unit_tests. BUG=None TEST=webkit_unit_tests --gtest_filter=WebCoreLayoutUnit* R=abarth@chromium.org

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #

Patch Set 3 : add it to win branch - makes sense? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -263 lines) Patch
M Source/WebKit/chromium/WebKit.gypi View 1 2 3 chunks +7 lines, -5 lines 0 comments Download
A + Source/WebKit/chromium/tests/LayoutUnitTest.cpp View 1 2 chunks +4 lines, -3 lines 0 comments Download
M Tools/TestWebKitAPI/TestWebKitAPI.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D Tools/TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp View 1 chunk +0 lines, -254 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tfarina
7 years, 8 months ago (2013-04-14 16:58:16 UTC) #1
abarth-chromium
LGTM I have some worry that this will cause problems with the component build. Would ...
7 years, 8 months ago (2013-04-14 17:47:07 UTC) #2
tfarina
On 2013/04/14 17:47:07, abarth wrote: > git wktry -b win:compile > Done. https://codereview.chromium.org/13881010/diff/1/Source/WebKit/chromium/tests/LayoutUnitTest.cpp File Source/WebKit/chromium/tests/LayoutUnitTest.cpp ...
7 years, 8 months ago (2013-04-14 18:11:18 UTC) #3
tfarina
Actually this is failing in win trybot. :( http://build.chromium.org/p/tryserver.chromium/builders/win/builds/64411/steps/runhooks/logs/stdio
7 years, 8 months ago (2013-04-14 18:27:52 UTC) #4
tfarina
Abandoning this patch for now. No idea what is going on with Windows try bot. ...
7 years, 8 months ago (2013-04-14 22:07:25 UTC) #5
abarth-chromium
7 years, 8 months ago (2013-04-14 22:28:48 UTC) #6
Message was sent while issue was closed.
That looks more like a problem with the try bot than a problem with the patch. 
It's missing the input file as if it didn't apply the patch properly...

Powered by Google App Engine
This is Rietveld 408576698