Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(756)

Issue 1388093002: Fix SVGUseElement "instance tree loading" status check (Closed)

Created:
5 years, 2 months ago by fs
Modified:
5 years, 2 months ago
Reviewers:
pdr.
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix SVGUseElement "instance tree loading" status check SVGUseElement::instanceTreeIsLoading was not checking the loading status of the immediate <use> targer (the |targetInstance| argument to the method.) It also wasn't checking the correct element for loading status, since correspondingUseElement() will return the containing (innermost) shadow host - which is not the <use> that will carry the relevant loading status. Make sure to check the immediate target, and check the loading status of any <use> elements encountered (instead of attempting to look at the "corresponding <use>"). Also rewrite the checker method to use Traversal<...>::next instead of being recursive, and simplify resourceIsStillLoading() some. BUG=232901 Committed: https://crrev.com/4cb58892e58014f15722c3375c6da072244e56b2 Cr-Commit-Position: refs/heads/master@{#352645}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
A third_party/WebKit/LayoutTests/svg/custom/use-nested-extern-href-non-existent-crash.html View 1 chunk +15 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/svg/custom/use-nested-extern-href-non-existent-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGUseElement.cpp View 1 chunk +3 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
5 years, 2 months ago (2015-10-06 15:21:20 UTC) #2
pdr.
On 2015/10/06 at 15:21:20, fs wrote: > LGTM!
5 years, 2 months ago (2015-10-06 17:03:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1388093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1388093002/1
5 years, 2 months ago (2015-10-06 17:04:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-06 18:11:17 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 18:12:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4cb58892e58014f15722c3375c6da072244e56b2
Cr-Commit-Position: refs/heads/master@{#352645}

Powered by Google App Engine
This is Rietveld 408576698