src/core/SkPicturePlayback.cpp - Issue 138803005: Set write buffer flags only in SkWriteBuffer and SkFlatController constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkPicturePlayback.cpp

Issue 138803005: Set write buffer flags only in SkWriteBuffer and SkFlatController constructors. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: INHERITED Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/core/SkPicturePlayback.cpp

diff --git a/src/core/SkPicturePlayback.cpp b/src/core/SkPicturePlayback.cpp

index 02d882897738f4d5b02a31ecd3a7d1615d1a9d2e..e71a17fda51095ec44fa49d4e4aa6f81b2493b0b 100644

--- a/src/core/SkPicturePlayback.cpp

+++ b/src/core/SkPicturePlayback.cpp

@@ -411,8 +411,7 @@ void SkPicturePlayback::serialize(SkWStream* stream,

SkRefCntSet typefaceSet;

SkFactorySet factSet;

- SkWriteBuffer buffer;

- buffer.setFlags(SkWriteBuffer::kCrossProcess_Flag);

+ SkWriteBuffer buffer(SkWriteBuffer::kCrossProcess_Flag);

buffer.setTypefaceRecorder(&typefaceSet);

buffer.setFactoryRecorder(&factSet);

buffer.setBitmapEncoder(encoder);

« no previous file with comments | « src/core/SkPictureFlat.cpp ('k') | src/core/SkWriteBuffer.cpp » ('j') | no next file with comments »