Issue 138803002: SPDY4: Turn SYN_STREAM and SYN_REPLY into HEADERS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 138803002: SPDY4: Turn SYN_STREAM and SYN_REPLY into HEADERS. (Closed)

Created:
6 years, 11 months ago by Johnny

Modified:
6 years, 11 months ago

Reviewers:
akalin

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

SPDY4: Turn SYN_STREAM and SYN_REPLY into HEADERS. Someday we will rip out support for SYN_STREAM altogether, but that will likely wait until we rip out SPDY <4. This lands server change 56555536 by hkhalil. Also updated SpdySession to work around removal of SYN_STREAM/SYN_REPLY: * OnSynReply() won't be called in SPDY4 contexts. OnHeaders() must handle initial response headers. * As OnPushPromise() isn't handled, associated stream checks aren't possible in SPDY4. Disable checks & related unit-tests. Also updated compression test fixtures. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245253

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+262 lines, -112 lines)			Patch
M	net/spdy/buffered_spdy_framer_unittest.cc	View	1	1 chunk	+7 lines, -2 lines	0 comments	Download
M	net/spdy/spdy_framer.cc	View	1 2	11 chunks	+68 lines, -18 lines	0 comments	Download
M	net/spdy/spdy_framer_test.cc	View	1	21 chunks	+121 lines, -81 lines	0 comments	Download
M	net/spdy/spdy_network_transaction_unittest.cc	View	1	6 chunks	+26 lines, -3 lines	0 comments	Download
M	net/spdy/spdy_protocol.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	net/spdy/spdy_session.cc	View	1	5 chunks	+36 lines, -8 lines	0 comments	Download