Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Side by Side Diff: tools/testing/dart/test_options.dart

Issue 13880030: Remove special casing for browser timeout (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library test_options_parser; 5 library test_options_parser;
6 6
7 import "dart:io"; 7 import "dart:io";
8 import "dart:math"; 8 import "dart:math";
9 import "drt_updater.dart"; 9 import "drt_updater.dart";
10 import "test_suite.dart"; 10 import "test_suite.dart";
(...skipping 590 matching lines...) Expand 10 before | Expand all | Expand 10 after
601 if (configuration['mode'] == 'debug') { 601 if (configuration['mode'] == 'debug') {
602 timeout *= 8; 602 timeout *= 8;
603 } 603 }
604 if (configuration['host_checked']) { 604 if (configuration['host_checked']) {
605 timeout *= 16; 605 timeout *= 16;
606 } 606 }
607 if (configuration['checked']) { 607 if (configuration['checked']) {
608 timeout *= 2; 608 timeout *= 2;
609 } 609 }
610 610
611 const BROWSERS = const [
612 'ie9', 'ie10', 'ff', 'chrome', 'safari', 'opera'
613 ];
614
615 if (BROWSERS.contains(configuration['runtime'])) {
616 timeout *= 8; // Allow additional time for browser testing to run.
617 }
618 break; 611 break;
619 default: 612 default:
620 if (configuration['mode'] == 'debug') { 613 if (configuration['mode'] == 'debug') {
621 timeout *= 2; 614 timeout *= 2;
622 } 615 }
623 if (const ['drt', 'dartium'].contains(configuration['runtime'])) { 616 if (const ['drt', 'dartium'].contains(configuration['runtime'])) {
624 timeout *= 4; // Allow additional time for browser testing to run. 617 timeout *= 4; // Allow additional time for browser testing to run.
625 } 618 }
626 break; 619 break;
627 } 620 }
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
699 return option; 692 return option;
700 } 693 }
701 } 694 }
702 print('Unknown test option $name'); 695 print('Unknown test option $name');
703 exit(1); 696 exit(1);
704 } 697 }
705 698
706 699
707 List<_TestOptionSpecification> _options; 700 List<_TestOptionSpecification> _options;
708 } 701 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698