Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13880029: Add new InternetAddress class with a static lookup function (including IPv6 results). (Closed)

Created:
7 years, 8 months ago by Anders Johnsen
Modified:
7 years, 8 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add new InternetAddress class with a static lookup function (including IPv6 results). Reapply of https://codereview.chromium.org/14083007/ with fixes. BUG= Committed: https://code.google.com/p/dart/source/detail?r=21923

Patch Set 1 #

Patch Set 2 : Fix io_patch and http pkg. #

Patch Set 3 : Clean up Macro's to static methods, that unions union for casting. #

Patch Set 4 : #

Patch Set 5 : Merge with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+877 lines, -425 lines) Patch
M pkg/http/test/utils.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/dbg_connection.cc View 1 chunk +5 lines, -1 line 0 comments Download
M runtime/bin/secure_socket.cc View 1 chunk +8 lines, -10 lines 0 comments Download
M runtime/bin/socket.h View 1 2 3 4 chunks +112 lines, -5 lines 0 comments Download
M runtime/bin/socket.cc View 5 chunks +66 lines, -17 lines 0 comments Download
M runtime/bin/socket_android.cc View 8 chunks +82 lines, -59 lines 0 comments Download
M runtime/bin/socket_linux.cc View 1 2 3 6 chunks +66 lines, -58 lines 0 comments Download
M runtime/bin/socket_macos.cc View 8 chunks +79 lines, -52 lines 0 comments Download
M runtime/bin/socket_patch.dart View 8 chunks +108 lines, -49 lines 0 comments Download
M runtime/bin/socket_win.cc View 7 chunks +82 lines, -65 lines 0 comments Download
M runtime/bin/vmstats_impl.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/io_patch.dart View 1 1 chunk +7 lines, -0 lines 0 comments Download
M sdk/lib/io/http_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/secure_socket.dart View 10 chunks +20 lines, -12 lines 0 comments Download
M sdk/lib/io/socket.dart View 6 chunks +83 lines, -8 lines 0 comments Download
M tests/standalone/io/http_close_test.dart View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M tests/standalone/io/http_compression_test.dart View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/io/http_keep_alive_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_proxy_test.dart View 12 chunks +13 lines, -13 lines 0 comments Download
M tests/standalone/io/http_server_early_client_close_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/https_client_certificate_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/standalone/io/https_client_exception_test.dart View 1 chunk +0 lines, -5 lines 0 comments Download
M tests/standalone/io/https_server_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/standalone/io/raw_secure_server_closing_test.dart View 5 chunks +4 lines, -5 lines 0 comments Download
M tests/standalone/io/raw_secure_server_socket_test.dart View 1 2 3 4 6 chunks +8 lines, -9 lines 0 comments Download
M tests/standalone/io/raw_secure_socket_pause_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/raw_secure_socket_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/secure_client_raw_server_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/standalone/io/secure_client_server_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/standalone/io/secure_multiple_client_server_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/standalone/io/secure_server_client_certificate_test.dart View 4 chunks +4 lines, -5 lines 0 comments Download
M tests/standalone/io/secure_server_closing_test.dart View 5 chunks +4 lines, -5 lines 0 comments Download
M tests/standalone/io/secure_server_socket_test.dart View 1 2 3 4 6 chunks +7 lines, -8 lines 0 comments Download
M tests/standalone/io/secure_session_resume_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/standalone/io/secure_socket_bad_certificate_test.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M tests/standalone/io/secure_socket_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A tests/standalone/io/socket_ipv6_test.dart View 1 chunk +88 lines, -0 lines 0 comments Download
M tests/standalone/io/socket_upgrade_to_secure_test.dart View 2 chunks +1 line, -2 lines 0 comments Download
M tests/standalone/io/web_socket_test.dart View 1 2 3 4 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
7 years, 8 months ago (2013-04-24 06:44:53 UTC) #1
Søren Gjesse
LGTM If this fixes the Linux GCC issues we should port these changes to the ...
7 years, 8 months ago (2013-04-24 06:58:19 UTC) #2
Anders Johnsen
7 years, 8 months ago (2013-04-24 07:12:34 UTC) #3
Message was sent while issue was closed. 
Committed patchset #5 manually as r21923 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698