net/disk_cache/simple/simple_synchronous_entry.cc - Issue 13880016: Make SimpleEntryImpl ref counted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/disk_cache/simple/simple_synchronous_entry.cc

Issue 13880016: Make SimpleEntryImpl ref counted. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: remove flaky dchecks Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/disk_cache/simple/simple_synchronous_entry.cc

diff --git a/net/disk_cache/simple/simple_synchronous_entry.cc b/net/disk_cache/simple/simple_synchronous_entry.cc

index 11a742199335d65dbd6af118ca01d15467ad2074..509755a0508ad76243c2a29f3e37576c53ac19ef 100644

--- a/net/disk_cache/simple/simple_synchronous_entry.cc

+++ b/net/disk_cache/simple/simple_synchronous_entry.cc

@@ -85,7 +85,7 @@ void SimpleSynchronousEntry::CreateEntry(

void SimpleSynchronousEntry::DoomEntry(

const FilePath& path,

const std::string& key,

- scoped_refptr<TaskRunner> callback_runner,

+ const scoped_refptr<TaskRunner>& callback_runner,

const net::CompletionCallback& callback) {

for (int i = 0; i < kSimpleEntryFileCount; ++i) {

FilePath to_delete = path.AppendASCII(GetFilenameFromKeyAndIndex(key, i));