Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: net/disk_cache/simple/simple_backend_impl.cc

Issue 13880016: Make SimpleEntryImpl ref counted. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove flaky dchecks Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/disk_cache/simple/simple_backend_impl.cc
diff --git a/net/disk_cache/simple/simple_backend_impl.cc b/net/disk_cache/simple/simple_backend_impl.cc
index 8b8bef4ca48e8a918fea0d6d0e2eda28b3eee16a..06176379a5b3d4bc0eebff201c12203d239d3611 100644
--- a/net/disk_cache/simple/simple_backend_impl.cc
+++ b/net/disk_cache/simple/simple_backend_impl.cc
@@ -78,20 +78,18 @@ int32 SimpleBackendImpl::GetEntryCount() const {
int SimpleBackendImpl::OpenEntry(const std::string& key,
Entry** entry,
const CompletionCallback& callback) {
- return SimpleEntryImpl::OpenEntry(
- index_->AsWeakPtr(), path_, key, entry, callback);
+ return SimpleEntryImpl::OpenEntry(index_, path_, key, entry, callback);
rvargas (doing something else) 2013/04/17 19:56:38 the weak pointer seems like a better approach.
}
int SimpleBackendImpl::CreateEntry(const std::string& key,
Entry** entry,
const CompletionCallback& callback) {
- return SimpleEntryImpl::CreateEntry(
- index_->AsWeakPtr(), path_, key, entry, callback);
+ return SimpleEntryImpl::CreateEntry(index_, path_, key, entry, callback);
}
int SimpleBackendImpl::DoomEntry(const std::string& key,
const net::CompletionCallback& callback) {
- return SimpleEntryImpl::DoomEntry(index_->AsWeakPtr(), path_, key, callback);
+ return SimpleEntryImpl::DoomEntry(index_, path_, key, callback);
}
int SimpleBackendImpl::DoomAllEntries(const CompletionCallback& callback) {

Powered by Google App Engine
This is Rietveld 408576698