Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 13880007: Fix set-up of intrinsics' 'constructor' properties (Closed)

Created:
7 years, 8 months ago by rossberg
Modified:
7 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Fix set-up of intrinsic's 'constructor' properties Looks so easy... R=mstarzinger@chromium.org BUG=229445 Committed: http://code.google.com/p/v8/source/detail?r=14229

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -11 lines) Patch
M src/factory.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/v8natives.js View 4 chunks +3 lines, -4 lines 0 comments Download
M test/mjsunit/harmony/symbols.js View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rossberg
7 years, 8 months ago (2013-04-11 12:10:56 UTC) #1
Michael Starzinger
LGTM. But it will need to be rebased.
7 years, 8 months ago (2013-04-11 12:16:37 UTC) #2
rossberg
7 years, 8 months ago (2013-04-11 12:28:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14229 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698