mojo/public/cpp/bindings/tests/map_unittest.cc - Issue 1387993002: mojo::Serialize*_() calls now propogate/return validation errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/tests/map_unittest.cc

Issue 1387993002: mojo::Serialize*_() calls now propogate/return validation errors. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Fixed MOJO_DCHECK issues, removed SerializationWarningObserver & addressing trung's CL comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/cpp/bindings/tests/map_unittest.cc

diff --git a/mojo/public/cpp/bindings/tests/map_unittest.cc b/mojo/public/cpp/bindings/tests/map_unittest.cc

index 9a1525326ada98b2fb5112bead2df90012ea7af9..499a67b68df0363c4cf1e2f37d1a344c1359835b 100644

--- a/mojo/public/cpp/bindings/tests/map_unittest.cc

+++ b/mojo/public/cpp/bindings/tests/map_unittest.cc

@@ -246,7 +246,8 @@ TEST_F(MapTest, ArrayOfMap) {

Array_Data<Map_Data<int32_t, int8_t>*>* data;

ArrayValidateParams validate_params(

0, false, new ArrayValidateParams(0, false, nullptr));

- SerializeArray_(&array, &buf, &data, &validate_params);

+ EXPECT_EQ(internal::VALIDATION_ERROR_NONE,

+ SerializeArray_(&array, &buf, &data, &validate_params));

Array<Map<int32_t, int8_t>> deserialized_array;

Deserialize_(data, &deserialized_array);

@@ -269,7 +270,8 @@ TEST_F(MapTest, ArrayOfMap) {

ArrayValidateParams validate_params(

0, false, new ArrayValidateParams(

0, false, new ArrayValidateParams(0, false, nullptr)));

- SerializeArray_(&array, &buf, &data, &validate_params);

+ EXPECT_EQ(internal::VALIDATION_ERROR_NONE,

+ SerializeArray_(&array, &buf, &data, &validate_params));

Array<Map<String, Array<bool>>> deserialized_array;

Deserialize_(data, &deserialized_array);