mojo/public/cpp/bindings/lib/map_serialization_forward.h - Issue 1387993002: mojo::Serialize*_() calls now propogate/return validation errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/lib/map_serialization_forward.h

Issue 1387993002: mojo::Serialize*_() calls now propogate/return validation errors. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Fixed MOJO_DCHECK issues, removed SerializationWarningObserver & addressing trung's CL comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/cpp/bindings/lib/map_serialization_forward.h

diff --git a/mojo/public/cpp/bindings/lib/map_serialization_forward.h b/mojo/public/cpp/bindings/lib/map_serialization_forward.h

index 40f6e8e16e79be139c8564b4661be60f3a5a434b..e6cd69fe3db0d6d53c63729070f343666acf994f 100644

--- a/mojo/public/cpp/bindings/lib/map_serialization_forward.h

+++ b/mojo/public/cpp/bindings/lib/map_serialization_forward.h

@@ -26,10 +26,11 @@ template <typename MapKey,

typename MapValue,

typename DataKey,

typename DataValue>

-void SerializeMap_(Map<MapKey, MapValue>* input,

- internal::Buffer* buf,

- internal::Map_Data<DataKey, DataValue>** output,

- const internal::ArrayValidateParams* value_validate_params);

+internal::ValidationError SerializeMap_(

+ Map<MapKey, MapValue>* input,

+ internal::Buffer* buf,

+ internal::Map_Data<DataKey, DataValue>** output,

+ const internal::ArrayValidateParams* value_validate_params);

template <typename MapKey, typename MapValue>

size_t GetSerializedSize_(const Map<MapKey, MapValue>& input);