mojo/public/cpp/bindings/tests/array_unittest.cc - Issue 1387993002: mojo::Serialize*_() calls now propogate/return validation errors.

Unified Diff: mojo/public/cpp/bindings/tests/array_unittest.cc

Issue 1387993002: mojo::Serialize*_() calls now propogate/return validation errors. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: unscope VALIDATION_ERROR_* enum values. early exit on null-input. additional comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/public/cpp/bindings/lib/validation_errors.h ('K') | « mojo/public/cpp/bindings/lib/validation_errors.h ('k') | mojo/public/cpp/bindings/tests/map_unittest.cc » ('j') | mojo/public/cpp/bindings/tests/map_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/cpp/bindings/tests/array_unittest.cc

diff --git a/mojo/public/cpp/bindings/tests/array_unittest.cc b/mojo/public/cpp/bindings/tests/array_unittest.cc

index ffee9cc907a87a1b87a9e434c94c9668d1fecec6..3eecd526d6a6241f25a7346f07f4a6651d9aa16a 100644

--- a/mojo/public/cpp/bindings/tests/array_unittest.cc

+++ b/mojo/public/cpp/bindings/tests/array_unittest.cc

@@ -161,7 +161,8 @@ TEST_F(ArrayTest, Serialization_ArrayOfPOD) {

FixedBufferForTesting buf(size);

Array_Data<int32_t>* data;

ArrayValidateParams validate_params(0, false, nullptr);

- SerializeArray_(&array, &buf, &data, &validate_params);

+ EXPECT_EQ(mojo::internal::VALIDATION_ERROR_NONE,

viettrungluu 2015/10/09 01:35:20 nit (here and below): Probably you can skip "mojo:

vardhan 2015/10/09 22:31:29 Unfortunately internal::VALIDATION_ERROR_NONE conf

+ SerializeArray_(&array, &buf, &data, &validate_params));

Array<int32_t> array2;

Deserialize_(data, &array2);

@@ -179,7 +180,8 @@ TEST_F(ArrayTest, Serialization_EmptyArrayOfPOD) {

FixedBufferForTesting buf(size);

Array_Data<int32_t>* data;

ArrayValidateParams validate_params(0, false, nullptr);

- SerializeArray_(&array, &buf, &data, &validate_params);

+ EXPECT_EQ(mojo::internal::VALIDATION_ERROR_NONE,

+ SerializeArray_(&array, &buf, &data, &validate_params));

Array<int32_t> array2;

Deserialize_(data, &array2);

@@ -202,7 +204,8 @@ TEST_F(ArrayTest, Serialization_ArrayOfArrayOfPOD) {

Array_Data<Array_Data<int32_t>*>* data;

ArrayValidateParams validate_params(

0, false, new ArrayValidateParams(0, false, nullptr));

- SerializeArray_(&array, &buf, &data, &validate_params);

+ EXPECT_EQ(mojo::internal::VALIDATION_ERROR_NONE,

+ SerializeArray_(&array, &buf, &data, &validate_params));

Array<Array<int32_t>> array2;

Deserialize_(data, &array2);

@@ -227,7 +230,8 @@ TEST_F(ArrayTest, Serialization_ArrayOfBool) {

FixedBufferForTesting buf(size);

Array_Data<bool>* data;

ArrayValidateParams validate_params(0, false, nullptr);

- SerializeArray_(&array, &buf, &data, &validate_params);

+ EXPECT_EQ(mojo::internal::VALIDATION_ERROR_NONE,

+ SerializeArray_(&array, &buf, &data, &validate_params));

Array<bool> array2;

Deserialize_(data, &array2);

@@ -255,7 +259,8 @@ TEST_F(ArrayTest, Serialization_ArrayOfString) {

Array_Data<String_Data*>* data;

ArrayValidateParams validate_params(

0, false, new ArrayValidateParams(0, false, nullptr));

- SerializeArray_(&array, &buf, &data, &validate_params);

+ EXPECT_EQ(mojo::internal::VALIDATION_ERROR_NONE,

+ SerializeArray_(&array, &buf, &data, &validate_params));

Array<String> array2;

Deserialize_(data, &array2);