mojo/public/cpp/bindings/tests/serialization_warning_unittest.cc - Issue 1387993002: mojo::Serialize*_() calls now propogate/return validation errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/tests/serialization_warning_unittest.cc

Issue 1387993002: mojo::Serialize*_() calls now propogate/return validation errors. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Cleaned up how serialization errors propagate, and addressed other comments from viettrungluu@ Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/cpp/bindings/tests/serialization_warning_unittest.cc

diff --git a/mojo/public/cpp/bindings/tests/serialization_warning_unittest.cc b/mojo/public/cpp/bindings/tests/serialization_warning_unittest.cc

index b61d3bc57e41482d50bbcbef8eb50b4683d3f132..3d89d565b5ae0d28e832f5cf651edbbebb20d4a0 100644

--- a/mojo/public/cpp/bindings/tests/serialization_warning_unittest.cc

+++ b/mojo/public/cpp/bindings/tests/serialization_warning_unittest.cc

@@ -61,7 +61,7 @@ class SerializationWarningTest : public testing::Test {

mojo::internal::FixedBufferForTesting buf(GetSerializedSize_(*obj));

typename T::Data_* data;

- Serialize_(obj.get(), &buf, &data);

+ EXPECT_EQ(expected_warning, Serialize_(obj.get(), &buf, &data));

EXPECT_EQ(expected_warning, warning_observer_.last_warning());

}

@@ -74,7 +74,8 @@ class SerializationWarningTest : public testing::Test {

mojo::internal::FixedBufferForTesting buf(GetSerializedSize_(obj));

typename T::Data_* data;

- SerializeArray_(&obj, &buf, &data, validate_params);

+ EXPECT_EQ(expected_warning,

+ SerializeArray_(&obj, &buf, &data, validate_params));

EXPECT_EQ(expected_warning, warning_observer_.last_warning());

}