mojo/public/cpp/bindings/lib/control_message_handler.cc - Issue 1387993002: mojo::Serialize*_() calls now propogate/return validation errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/lib/control_message_handler.cc

Issue 1387993002: mojo::Serialize*_() calls now propogate/return validation errors. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Cleaned up how serialization errors propagate, and addressed other comments from viettrungluu@ Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/cpp/bindings/lib/control_message_handler.cc

diff --git a/mojo/public/cpp/bindings/lib/control_message_handler.cc b/mojo/public/cpp/bindings/lib/control_message_handler.cc

index 0c4698273318675b8a6e245073dd61d978b6eac1..dbc76ef84e6547d343e5d957527098b9e4fafb30 100644

--- a/mojo/public/cpp/bindings/lib/control_message_handler.cc

+++ b/mojo/public/cpp/bindings/lib/control_message_handler.cc

@@ -56,7 +56,9 @@ bool ControlMessageHandler::Run(Message* message,

ResponseMessageBuilder builder(kRunMessageId, size, message->request_id());

RunResponseMessageParams_Data* response_params = nullptr;

- Serialize_(response_params_ptr.get(), builder.buffer(), &response_params);

+ MOJO_DCHECK(Serialize_(response_params_ptr.get(), builder.buffer(),

+ &response_params) ==

+ ValidationError::VALIDATION_ERROR_NONE);

response_params->EncodePointersAndHandles(

builder.message()->mutable_handles());

bool ok = responder->Accept(builder.message());