Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1299)

Unified Diff: mojo/public/cpp/bindings/lib/control_message_proxy.cc

Issue 1387993002: mojo::Serialize*_() calls now propogate/return validation errors. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/public/cpp/bindings/lib/control_message_proxy.cc
diff --git a/mojo/public/cpp/bindings/lib/control_message_proxy.cc b/mojo/public/cpp/bindings/lib/control_message_proxy.cc
index ee1e695bbd2d86bbf304f3d4a58dcda9d97fca7f..5b1491159ccfc32da5157273a6112bec54c754c7 100644
--- a/mojo/public/cpp/bindings/lib/control_message_proxy.cc
+++ b/mojo/public/cpp/bindings/lib/control_message_proxy.cc
@@ -52,7 +52,8 @@ void SendRunMessage(MessageReceiverWithResponder* receiver,
RequestMessageBuilder builder(kRunMessageId, size);
RunMessageParams_Data* params = nullptr;
- Serialize_(params_ptr.get(), builder.buffer(), &params);
+ MOJO_DCHECK(Serialize_(params_ptr.get(), builder.buffer(), &params) ==
+ ValidationError::VALIDATION_ERROR_NONE);
params->EncodePointersAndHandles(builder.message()->mutable_handles());
MessageReceiver* responder = new RunResponseForwardToCallback(callback);
if (!receiver->AcceptWithResponder(builder.message(), responder))
@@ -70,7 +71,8 @@ void SendRunOrClosePipeMessage(MessageReceiverWithResponder* receiver,
MessageBuilder builder(kRunOrClosePipeMessageId, size);
RunOrClosePipeMessageParams_Data* params = nullptr;
- Serialize_(params_ptr.get(), builder.buffer(), &params);
+ MOJO_DCHECK(Serialize_(params_ptr.get(), builder.buffer(), &params) ==
+ ValidationError::VALIDATION_ERROR_NONE);
params->EncodePointersAndHandles(builder.message()->mutable_handles());
bool ok = receiver->Accept(builder.message());
MOJO_ALLOW_UNUSED_LOCAL(ok);

Powered by Google App Engine
This is Rietveld 408576698