mojo::Serialize*_() calls now propogate/return validation errors.

mojo/public/cpp/bindings/lib/validation_errors.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MOJO_PUBLIC_CPP_BINDINGS_LIB_VALIDATION_ERRORS_H_
 #define MOJO_PUBLIC_CPP_BINDINGS_LIB_VALIDATION_ERRORS_H_
 
 #include "mojo/public/cpp/system/macros.h"
 
 namespace mojo {
@@ skipping 85 matching lines @@
 
  private:
   ValidationError last_warning_;
 
   MOJO_DISALLOW_COPY_AND_ASSIGN(SerializationWarningObserverForTesting);
 };
 
 }  // namespace internal
 }  // namespace mojo
 
-// In debug build, logs a serialization warning if |condition| evaluates to
-// true:
+// In debug build, logs a serialization warning:

[viettrungluu, 2015/10/09 01:35:19]

nit (pre-existing condition): "debug" -> "a debug"

[vardhan, 2015/10/09 22:31:28]

Done.

 //   - if there is a SerializationWarningObserverForTesting object alive,
 //     records |error| in it;
 //   - otherwise, logs a fatal-level message.
 // |error| is the validation error that will be triggered by the receiver
 // of the serialzation result.
 //
 // In non-debug build, does nothing (not even compiling |condition|).

[viettrungluu, 2015/10/09 01:35:20]

Remove the "(not even compiling ...)" bit.

(Incidentally, that comment was wrong to begin with.)

[vardhan, 2015/10/09 22:31:29]

Removed.
(That's really weird!  Why is it DLOG? should we rename.. at some point?)

-#define MOJO_INTERNAL_DLOG_SERIALIZATION_WARNING(                        \
-    condition, error, description)                                       \
-  MOJO_DLOG_IF(FATAL, (condition) && !ReportSerializationWarning(error)) \
-      << "The outgoing message will trigger "                            \
-      << ValidationErrorToString(error) << " at the receiving side ("    \
-      << description << ").";
+#define MOJO_INTERNAL_DLOG_SERIALIZATION_WARNING(error, description)  \
+  MOJO_DLOG_IF(FATAL, !ReportSerializationWarning(error))             \
+      << "The outgoing message will trigger "                         \
+      << ValidationErrorToString(error) << " at the receiving side (" \
+      << description << ")."
 
 #endif  // MOJO_PUBLIC_CPP_BINDINGS_LIB_VALIDATION_ERRORS_H_