mojo::Serialize*_() calls now propogate/return validation errors.

mojo/public/cpp/bindings/tests/array_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/public/cpp/bindings/array.h"
 #include "mojo/public/cpp/bindings/lib/array_internal.h"
 #include "mojo/public/cpp/bindings/lib/array_serialization.h"
 #include "mojo/public/cpp/bindings/lib/fixed_buffer.h"
 #include "mojo/public/cpp/bindings/tests/container_test_util.h"
 #include "mojo/public/cpp/bindings/tests/iterator_test_util.h"
@@ skipping 143 matching lines @@
   Array<int32_t> array(4);
   for (size_t i = 0; i < array.size(); ++i)
     array[i] = static_cast<int32_t>(i);
 
   size_t size = GetSerializedSize_(array);
   EXPECT_EQ(8U + 4 * 4U, size);
 
   FixedBufferForTesting buf(size);
   Array_Data<int32_t>* data;
   ArrayValidateParams validate_params(0, false, nullptr);
-  SerializeArray_(&array, &buf, &data, &validate_params);
+  EXPECT_EQ(mojo::internal::ValidationError::VALIDATION_ERROR_NONE,
+            SerializeArray_(&array, &buf, &data, &validate_params));
 
   Array<int32_t> array2;
   Deserialize_(data, &array2);
 
   EXPECT_EQ(4U, array2.size());
   for (size_t i = 0; i < array2.size(); ++i)
     EXPECT_EQ(static_cast<int32_t>(i), array2[i]);
 }
 
 TEST_F(ArrayTest, Serialization_EmptyArrayOfPOD) {
   Array<int32_t> array(0);
   size_t size = GetSerializedSize_(array);
   EXPECT_EQ(8U, size);
 
   FixedBufferForTesting buf(size);
   Array_Data<int32_t>* data;
   ArrayValidateParams validate_params(0, false, nullptr);
-  SerializeArray_(&array, &buf, &data, &validate_params);
+  EXPECT_EQ(mojo::internal::ValidationError::VALIDATION_ERROR_NONE,
+            SerializeArray_(&array, &buf, &data, &validate_params));
 
   Array<int32_t> array2;
   Deserialize_(data, &array2);
   EXPECT_EQ(0U, array2.size());
 }
 
 TEST_F(ArrayTest, Serialization_ArrayOfArrayOfPOD) {
   Array<Array<int32_t>> array(2);
   for (size_t j = 0; j < array.size(); ++j) {
     Array<int32_t> inner(4);
     for (size_t i = 0; i < inner.size(); ++i)
       inner[i] = static_cast<int32_t>(i + (j * 10));
     array[j] = inner.Pass();
   }
 
   size_t size = GetSerializedSize_(array);
   EXPECT_EQ(8U + 2 * 8U + 2 * (8U + 4 * 4U), size);
 
   FixedBufferForTesting buf(size);
   Array_Data<Array_Data<int32_t>*>* data;
   ArrayValidateParams validate_params(
       0, false, new ArrayValidateParams(0, false, nullptr));
-  SerializeArray_(&array, &buf, &data, &validate_params);
+  EXPECT_EQ(mojo::internal::ValidationError::VALIDATION_ERROR_NONE,
+            SerializeArray_(&array, &buf, &data, &validate_params));
 
   Array<Array<int32_t>> array2;
   Deserialize_(data, &array2);
 
   EXPECT_EQ(2U, array2.size());
   for (size_t j = 0; j < array2.size(); ++j) {
     const Array<int32_t>& inner = array2[j];
     EXPECT_EQ(4U, inner.size());
     for (size_t i = 0; i < inner.size(); ++i)
       EXPECT_EQ(static_cast<int32_t>(i + (j * 10)), inner[i]);
   }
 }
 
 TEST_F(ArrayTest, Serialization_ArrayOfBool) {
   Array<bool> array(10);
   for (size_t i = 0; i < array.size(); ++i)
     array[i] = i % 2 ? true : false;
 
   size_t size = GetSerializedSize_(array);
   EXPECT_EQ(8U + 8U, size);
 
   FixedBufferForTesting buf(size);
   Array_Data<bool>* data;
   ArrayValidateParams validate_params(0, false, nullptr);
-  SerializeArray_(&array, &buf, &data, &validate_params);
+  EXPECT_EQ(mojo::internal::ValidationError::VALIDATION_ERROR_NONE,
+            SerializeArray_(&array, &buf, &data, &validate_params));
 
   Array<bool> array2;
   Deserialize_(data, &array2);
 
   EXPECT_EQ(10U, array2.size());
   for (size_t i = 0; i < array2.size(); ++i)
     EXPECT_EQ(i % 2 ? true : false, array2[i]);
 }
 
 TEST_F(ArrayTest, Serialization_ArrayOfString) {
   Array<String> array(10);
   for (size_t i = 0; i < array.size(); ++i) {
     char c = 'A' + static_cast<char>(i);
     array[i] = String(&c, 1);
   }
 
   size_t size = GetSerializedSize_(array);
   EXPECT_EQ(8U +            // array header
                 10 * 8U +   // array payload (10 pointers)
                 10 * (8U +  // string header
                       8U),  // string length of 1 padded to 8
             size);
 
   FixedBufferForTesting buf(size);
   Array_Data<String_Data*>* data;
   ArrayValidateParams validate_params(
       0, false, new ArrayValidateParams(0, false, nullptr));
-  SerializeArray_(&array, &buf, &data, &validate_params);
+  EXPECT_EQ(mojo::internal::ValidationError::VALIDATION_ERROR_NONE,
+            SerializeArray_(&array, &buf, &data, &validate_params));
 
   Array<String> array2;
   Deserialize_(data, &array2);
 
   EXPECT_EQ(10U, array2.size());
   for (size_t i = 0; i < array2.size(); ++i) {
     char c = 'A' + static_cast<char>(i);
     EXPECT_EQ(String(&c, 1), array2[i]);
   }
 }
@@ skipping 217 matching lines @@
   {
     SCOPED_TRACE("Array iterator bidirectionality test.");
     ExpectBidiIteratorConcept(arr.begin(), arr.end(), values);
     ExpectBidiMutableIteratorConcept(arr.begin(), arr.end(), values);
   }
 }
 
 }  // namespace
 }  // namespace test
 }  // namespace mojo