Adding error handlers to setup.exe

Adding error handlers to setup.exe.

The handlers make setup crash cleanly when we run out of memory, on heap corruption and on invalid parameters in the CRT.

Moved 2 functions from startup_helper_win to base target.
Renamed startup_helper_win to sandbox_helper_win now that it contains only a function related to the sandbox.

BUG=530624
Committed: https://crrev.com/18d3ed36f113ef9fb159d729ec5c89b578ece692
Cr-Commit-Position: refs/heads/master@{#354591}

[Patrick Monette, 2015-10-07 17:05:33]

Patchset #1 (id:1) has been deleted

[Patrick Monette, 2015-10-07 17:34:13]

pmonette@chromium.org changed reviewers:
+ brettw@chromium.org, grt@chromium.org

[Patrick Monette, 2015-10-07 17:34:13]

Functional changes are in setup_main.cc

The rest consist of splitting the content_startup_helper_win build target into 2
:
sandbox_helper_win and process_startup_helper_win.

grt@chromium.org: Please review changes in setup_main.cc

brettw@chromium.org: Need owners lgtm on everything and please review changes in
all BUILD.gn and *.gyp files.

Thanks!

[grt (UTC plus 2), 2015-10-08 11:52:08]

https://codereview.chromium.org/1387963006/diff/20001/base/base.gyp
File base/base.gyp (right):

https://codereview.chromium.org/1387963006/diff/20001/base/base.gyp#newcode1668
base/base.gyp:1668: 'target_name': 'process_startup_helper_win',
is this extra target needed? content_app_deps already depends on base/ directly,
so will everything hang together properly if the process_startup_helper.*
sources are simply included in the main base target?

https://codereview.chromium.org/1387963006/diff/20001/chrome/installer/setup/...
File chrome/installer/setup/setup_main.cc (right):

https://codereview.chromium.org/1387963006/diff/20001/chrome/installer/setup/...
chrome/installer/setup/setup_main.cc:1714: // Make sure the setup exits cleanly
on unexpected errors.
s/setup/process/

[Patrick Monette, 2015-10-08 21:22:47]

Responded to Greg's comments. Take another look please!

https://codereview.chromium.org/1387963006/diff/20001/base/base.gyp
File base/base.gyp (right):

https://codereview.chromium.org/1387963006/diff/20001/base/base.gyp#newcode1668
base/base.gyp:1668: 'target_name': 'process_startup_helper_win',
On 2015/10/08 11:52:08, grt (very slow until Oct 12) wrote:
> is this extra target needed? content_app_deps already depends on base/
directly,
> so will everything hang together properly if the process_startup_helper.*
> sources are simply included in the main base target?

You are right. Removed.

https://codereview.chromium.org/1387963006/diff/20001/chrome/installer/setup/...
File chrome/installer/setup/setup_main.cc (right):

https://codereview.chromium.org/1387963006/diff/20001/chrome/installer/setup/...
chrome/installer/setup/setup_main.cc:1714: // Make sure the setup exits cleanly
on unexpected errors.
On 2015/10/08 11:52:08, grt (very slow until Oct 12) wrote:
> s/setup/process/

Done.

[grt (UTC plus 2), 2015-10-09 15:06:02]

lgtm

[grt (UTC plus 2), 2015-10-09 15:06:45]

On 2015/10/09 15:06:02, grt (very slow until Oct 12) wrote:
> lgtm

Please update the CL description. It's a little out of date now ("Split
startup_helper_win into 2 build targets to reuse existing functions."). Thanks

[pmonette_google.com, 2015-10-09 17:03:22]

pmonette@google.com changed reviewers:
+ pmonette@google.com

[pmonette_google.com, 2015-10-09 17:03:22]

brett@ Can you take a look please?

[Patrick Monette, 2015-10-09 17:06:33]

pmonette@chromium.org changed reviewers:
- pmonette@google.com

[grt (UTC plus 2), 2015-10-14 19:51:03]

brettw: ping

[brettw, 2015-10-15 23:18:04]

lgtm

[Patrick Monette, 2015-10-16 04:01:21]

The CQ bit was checked by pmonette@chromium.org

[commit-bot: I haz the power, 2015-10-16 04:02:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1387963006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1387963006/40001

[commit-bot: I haz the power, 2015-10-16 04:04:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-16 04:04:10]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Patrick Monette, 2015-10-16 17:31:31]

The CQ bit was checked by pmonette@chromium.org

[Patrick Monette, 2015-10-16 17:31:31]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org,
grt@chromium.org
Link to the patchset: https://codereview.chromium.org/1387963006/#ps80001
(title: "Fix lint errors/warnings")

[commit-bot: I haz the power, 2015-10-16 17:32:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1387963006/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1387963006/80001

[commit-bot: I haz the power, 2015-10-16 20:04:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-16 20:04:31]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Patrick Monette, 2015-10-16 20:10:03]

The CQ bit was checked by pmonette@chromium.org

[commit-bot: I haz the power, 2015-10-16 20:10:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1387963006/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1387963006/80001

[commit-bot: I haz the power, 2015-10-16 21:06:15]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-10-16 21:07:25]

Patchset 4 (id:??) landed as
https://crrev.com/18d3ed36f113ef9fb159d729ec5c89b578ece692
Cr-Commit-Position: refs/heads/master@{#354591}