unittest/IceParseInstsTest.cpp - Issue 1387963002: Make sure that all globals are internal, except for "start" functions.

Unified Diff: unittest/IceParseInstsTest.cpp

Issue 1387963002: Make sure that all globals are internal, except for "start" functions. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fix new tests. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: unittest/IceParseInstsTest.cpp

diff --git a/unittest/IceParseInstsTest.cpp b/unittest/IceParseInstsTest.cpp

index d58ad5a78472a5eae6d7426db141f1b5e7f11a8e..8b452d3e2b3480d60b31b7166cfb39e8cad86ad8 100644

--- a/unittest/IceParseInstsTest.cpp

+++ b/unittest/IceParseInstsTest.cpp

@@ -44,8 +44,8 @@ TEST(IceParseInstsTest, NonexistentCallArg) {

3, naclbitc::TYPE_CODE_VOID, Terminator,

3, naclbitc::TYPE_CODE_FUNCTION, 0, 1, 0, 0, Terminator,

0, naclbitc::BLK_CODE_EXIT, Terminator,

- 3, naclbitc::MODULE_CODE_FUNCTION, 2, 0, 1, 0, Terminator,

- 3, naclbitc::MODULE_CODE_FUNCTION, 2, 0, 0, 0, Terminator,

+ 3, naclbitc::MODULE_CODE_FUNCTION, 2, 0, 1, 3, Terminator,

+ 3, naclbitc::MODULE_CODE_FUNCTION, 2, 0, 0, 3, Terminator,

1, naclbitc::BLK_CODE_ENTER, naclbitc::FUNCTION_BLOCK_ID, 2, Terminator,

3, naclbitc::FUNC_CODE_DECLAREBLOCKS, 1, Terminator,

// Note: 100 is a bad value index in next line.

@@ -85,7 +85,7 @@ TEST(IceParseInstsTests, AllocaAlignment) {

3, naclbitc::TYPE_CODE_FUNCTION, 0, 1, 0, Terminator,

3, naclbitc::TYPE_CODE_INTEGER, 8, Terminator,

0, naclbitc::BLK_CODE_EXIT, Terminator,

- 3, naclbitc::MODULE_CODE_FUNCTION, 2, 0, 0, 0, Terminator,

+ 3, naclbitc::MODULE_CODE_FUNCTION, 2, 0, 0, 3, Terminator,

1, naclbitc::BLK_CODE_ENTER, naclbitc::FUNCTION_BLOCK_ID, 2, Terminator,

3, naclbitc::FUNC_CODE_DECLAREBLOCKS, 1, Terminator,

3, naclbitc::FUNC_CODE_INST_ALLOCA, 1, getEncAlignPower(0), Terminator,

@@ -152,7 +152,7 @@ TEST(IceParseInstsTests, LoadI32Alignment) {

3, naclbitc::TYPE_CODE_INTEGER, 32, Terminator,

3, naclbitc::TYPE_CODE_FUNCTION, 0, 0, 0, Terminator,

0, naclbitc::BLK_CODE_EXIT, Terminator,

- 3, naclbitc::MODULE_CODE_FUNCTION, 1, 0, 0, 0, Terminator,

+ 3, naclbitc::MODULE_CODE_FUNCTION, 1, 0, 0, 3, Terminator,

1, naclbitc::BLK_CODE_ENTER, naclbitc::FUNCTION_BLOCK_ID, 2, Terminator,

3, naclbitc::FUNC_CODE_DECLAREBLOCKS, 1, Terminator,

3, naclbitc::FUNC_CODE_INST_LOAD, 1, getEncAlignPower(0), 0, Terminator,

@@ -234,7 +234,7 @@ TEST(IceParseInstsTests, LoadFloatAlignment) {

3, naclbitc::TYPE_CODE_INTEGER, 32, Terminator,

3, naclbitc::TYPE_CODE_FUNCTION, 0, 0, 1, Terminator,

0, naclbitc::BLK_CODE_EXIT, Terminator,

- 3, naclbitc::MODULE_CODE_FUNCTION, 2, 0, 0, 0, Terminator,

+ 3, naclbitc::MODULE_CODE_FUNCTION, 2, 0, 0, 3, Terminator,

1, naclbitc::BLK_CODE_ENTER, naclbitc::FUNCTION_BLOCK_ID, 2, Terminator,

3, naclbitc::FUNC_CODE_DECLAREBLOCKS, 1, Terminator,

3, naclbitc::FUNC_CODE_INST_LOAD, 1, getEncAlignPower(0), 0, Terminator,

@@ -315,7 +315,7 @@ TEST(NaClParseInstsTests, StoreAlignment) {

3, naclbitc::TYPE_CODE_INTEGER, 32, Terminator,

3, naclbitc::TYPE_CODE_FUNCTION, 0, 0, 1, 0, Terminator,

0, naclbitc::BLK_CODE_EXIT, Terminator,

- 3, naclbitc::MODULE_CODE_FUNCTION, 2, 0, 0, 0, Terminator,

+ 3, naclbitc::MODULE_CODE_FUNCTION, 2, 0, 0, 3, Terminator,

1, naclbitc::BLK_CODE_ENTER, naclbitc::FUNCTION_BLOCK_ID, 2, Terminator,

3, naclbitc::FUNC_CODE_DECLAREBLOCKS, 1, Terminator,

3, naclbitc::FUNC_CODE_INST_STORE, 2, 1, getEncAlignPower(0), Terminator,

« no previous file with comments | « tests_lit/reader_tests/unnamed.ll ('k') | no next file » | no next file with comments »