tests_lit/reader_tests/globalrelocs.ll - Issue 1387963002: Make sure that all globals are internal, except for "start" functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests_lit/reader_tests/globalrelocs.ll

Issue 1387963002: Make sure that all globals are internal, except for "start" functions. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fix new tests. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests_lit/reader_tests/globalrelocs.ll

diff --git a/tests_lit/reader_tests/globalrelocs.ll b/tests_lit/reader_tests/globalrelocs.ll

index a6a44f706b36523916c9dcc7b96fa405573ea484..55d9524ca2395b9cff5fe102a0185d351944c780 100644

--- a/tests_lit/reader_tests/globalrelocs.ll

+++ b/tests_lit/reader_tests/globalrelocs.ll

@@ -93,10 +93,10 @@

@short = internal constant [2 x i8] zeroinitializer

; CHECK-NEXT: @short = internal constant [2 x i8] zeroinitializer

-define void @func() {

+define internal void @func() {

ret void

}

-; CHECK-NEXT: define void @func() {

+; CHECK-NEXT: define internal void @func() {

; NOIR: Total across all functions

« no previous file with comments | « tests_lit/reader_tests/globalinit.pnacl.ll ('k') | tests_lit/reader_tests/insertextract.ll » ('j') | no next file with comments »