tests_lit/parse_errs/symtab-after-fcn.test - Issue 1387963002: Make sure that all globals are internal, except for "start" functions.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tests_lit/parse_errs/symtab-after-fcn.test

Issue 1387963002: Make sure that all globals are internal, except for "start" functions. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Fix new tests. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 ; Test if we detect if the value symbol table appears after a function block.	1 ; Test if we detect if the value symbol table appears after a function block.

2	2

3 ; REQUIRES: no_minimal_build	3 ; REQUIRES: no_minimal_build

4	4

5 ; RUN: not %pnacl_sz -bitcode-as-text %p/Inputs/symtab-after-fcn.tbc \	5 ; RUN: not %pnacl_sz -bitcode-as-text %p/Inputs/symtab-after-fcn.tbc \

6 ; RUN: -bitcode-format=pnacl -notranslate -build-on-read 2>&1 \	6 ; RUN: -bitcode-format=pnacl -notranslate -build-on-read \

	7 ; RUN: -allow-externally-defined-symbols 2>&1 \

7 ; RUN: \| FileCheck %s	8 ; RUN: \| FileCheck %s

8	9

9 ; CHECK: Module valuesymtab not allowed after function blocks	10 ; CHECK: Module valuesymtab not allowed after function blocks

10	11

11 ; RUN: pnacl-bcfuzz -bitcode-as-text %p/Inputs/symtab-after-fcn.tbc \	12 ; RUN: pnacl-bcfuzz -bitcode-as-text %p/Inputs/symtab-after-fcn.tbc \

12 ; RUN: -output - \| not pnacl-bcdis -no-records \	13 ; RUN: -output - \| not pnacl-bcdis -no-records \

13 ; RUN: \| FileCheck -check-prefix=ASM %s	14 ; RUN: \| FileCheck -check-prefix=ASM %s

14	15

15 ; ASM: module { // BlockID = 8	16 ; ASM: module { // BlockID = 8

16 ; ASM: function void @f0() { // BlockID = 12	17 ; ASM: function void @f0() { // BlockID = 12

17 ; ASM: }	18 ; ASM: }

18 ; ASM: valuesymtab { // BlockID = 14	19 ; ASM: valuesymtab { // BlockID = 14

19 ; ASM: Error({{.*}}): Module symbol table must appear before function blocks	20 ; ASM: Error({{.*}}): Module symbol table must appear before function blocks

20 ; ASM: }	21 ; ASM: }

21 ; ASM: }	22 ; ASM: }

OLD	NEW

« no previous file with comments | « tests_lit/parse_errs/insertelt-wrong-type.test ('k') | tests_lit/reader_tests/alloca.ll » ('j') | no next file with comments »