Make sure that all globals are internal, except for "start" functions.

tests_lit/llvm2ice_tests/branch-opt.ll

 ; Tests the branch optimizations under O2 (against a lack of
 ; optimizations under Om1).
 
 ; RUN: %if --need=target_X8632 --command %p2i --filetype=obj --disassemble \
-; RUN:   --target x8632 -i %s --args -O2 \
+; RUN:   --target x8632 -i %s --args -O2 -allow-externally-defined-symbols \
 ; RUN:   | %if --need=target_X8632 --command FileCheck --check-prefix=O2 %s
 
 ; RUN: %if --need=target_X8632 --command %p2i --filetype=obj --disassemble \
-; RUN:   --target x8632 -i %s --args -Om1 \
+; RUN:   --target x8632 -i %s --args -Om1 -allow-externally-defined-symbols \
 ; RUN:   | %if --need=target_X8632 --command FileCheck --check-prefix=OM1 %s
 
 ; TODO(jvoung): Stop skipping unimplemented parts (via --skip-unimplemented)
 ; once enough infrastructure is in. Also, switch to --filetype=obj
 ; when possible.
 ; RUN: %if --need=target_ARM32 --need=allow_dump \
 ; RUN:   --command %p2i --filetype=asm --assemble \
 ; RUN:   --disassemble --target arm32 -i %s --args -O2 --skip-unimplemented \
+; RUN:   -allow-externally-defined-symbols \
 ; RUN:   | %if --need=target_ARM32 --need=allow_dump \
 ; RUN:   --command FileCheck --check-prefix ARM32O2 %s
 
 ; RUN: %if --need=target_ARM32 --need=allow_dump \
 ; RUN:   --command %p2i --filetype=asm --assemble \
 ; RUN:   --disassemble --target arm32 -i %s --args -Om1 --skip-unimplemented \
+; RUN:   -allow-externally-defined-symbols \
 ; RUN:   | %if --need=target_ARM32 --need=allow_dump \
 ; RUN:   --command FileCheck \
 ; RUN:   --check-prefix ARM32OM1 %s
 
 declare void @dummy()
 
 ; An unconditional branch to the next block should be removed.
-define void @testUncondToNextBlock() {
+define internal void @testUncondToNextBlock() {
 entry:
   call void @dummy()
   br label %next
 next:
   call void @dummy()
   ret void
 }
 ; O2-LABEL: testUncondToNextBlock
 ; O2: call
 ; There will be nops for bundle align to end (for NaCl), but there should
@@ skipping 10 matching lines @@
 ; ARM32O2: bl {{.*}} dummy
 ; ARM32O2-NEXT: bl {{.*}} dummy
 
 ; ARM32OM1-LABEL: testUncondToNextBlock
 ; ARM32OM1: bl {{.*}} dummy
 ; ARM32OM1-NEXT: b
 ; ARM32OM1-NEXT: bl {{.*}} dummy
 
 ; For a conditional branch with a fallthrough to the next block, the
 ; fallthrough branch should be removed.
-define void @testCondFallthroughToNextBlock(i32 %arg) {
+define internal void @testCondFallthroughToNextBlock(i32 %arg) {
 entry:
   %cmp = icmp sge i32 %arg, 123
   br i1 %cmp, label %target, label %fallthrough
 fallthrough:
   call void @dummy()
   ret void
 target:
   call void @dummy()
   ret void
 }
@@ skipping 36 matching lines @@
 ; ARM32OM1: b
 ; ARM32OM1: bl
 ; ARM32OM1: bx lr
 ; ARM32OM1: bl
 ; ARM32OM1: bx lr
 
 ; For a conditional branch with the next block as the target and a
 ; different block as the fallthrough, the branch condition should be
 ; inverted, the fallthrough block changed to the target, and the
 ; branch to the next block removed.
-define void @testCondTargetNextBlock(i32 %arg) {
+define internal void @testCondTargetNextBlock(i32 %arg) {
 entry:
   %cmp = icmp sge i32 %arg, 123
   br i1 %cmp, label %fallthrough, label %target
 fallthrough:
   call void @dummy()
   ret void
 target:
   call void @dummy()
   ret void
 }
@@ skipping 35 matching lines @@
 ; ARM32OM1: cmp {{.*}}, #0
 ; ARM32OM1: bne
 ; ARM32OM1: b
 ; ARM32OM1: bl
 ; ARM32OM1: bx lr
 ; ARM32OM1: bl
 ; ARM32OM1: bx lr
 
 ; Unconditional branches to the block after a contracted block should be
 ; removed.
-define void @testUncondToBlockAfterContract() {
+define internal void @testUncondToBlockAfterContract() {
 entry:
   call void @dummy()
   br label %target
 contract:
   br label %target
 target:
   call void @dummy()
   ret void
 }
 
@@ skipping 10 matching lines @@
 ; OM1: call
 
 ; ARM32O2-LABEL: testUncondToBlockAfterContract
 ; ARM32O2: bl {{.*}} dummy
 ; ARM32O2-NEXT: bl {{.*}} dummy
 
 ; ARM32OM1-LABEL: testUncondToBlockAfterContract
 ; ARM32OM1: bl {{.*}} dummy
 ; ARM32OM1-NEXT: b
 ; ARM32OM1-NEXT: bl {{.*}} dummy