Make sure that all globals are internal, except for "start" functions.

src/IceConverter.cpp

 //===- subzero/src/IceConverter.cpp - Converts LLVM to Ice  ---------------===//
 //
 //                        The Subzero Code Generator
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 ///
 /// \file
@@ skipping 849 matching lines @@
     FunctionType *FuncType = Func.getFunctionType();
     Signature.setReturnType(
         Converter.convertToIceType(FuncType->getReturnType()));
     for (size_t I = 0; I < FuncType->getNumParams(); ++I) {
       Signature.appendArgType(
           Converter.convertToIceType(FuncType->getParamType(I)));
     }
     FunctionDeclaration *IceFunc = FunctionDeclaration::create(
         Ctx, Signature, Func.getCallingConv(), Func.getLinkage(), Func.empty());
     IceFunc->setName(Func.getName());
+    if (!IceFunc->verifyLinkageCorrect(Ctx)) {
+      std::string Buffer;
+      raw_string_ostream StrBuf(Buffer);
+      StrBuf << "Function " << IceFunc->getName()
+             << " has incorrect linkage: " << IceFunc->getLinkageName();
+      report_fatal_error(StrBuf.str());
+    }
     GlobalDeclarationMap[&Func] = IceFunc;
   }
   // Install global variable declarations.
   for (Module::const_global_iterator I = Mod->global_begin(),
                                      E = Mod->global_end();
        I != E; ++I) {
     const GlobalVariable *GV = I;
     VariableDeclaration *Var = VariableDeclaration::create(Ctx);
     Var->setName(GV->getName());
     Var->setAlignment(GV->getAlignment());
     Var->setIsConstant(GV->isConstant());
     Var->setLinkage(GV->getLinkage());
+    if (!Var->verifyLinkageCorrect(Ctx)) {
+      std::string Buffer;
+      raw_string_ostream StrBuf(Buffer);
+      StrBuf << "Global " << Var->getName()
+             << " has incorrect linkage: " << Var->getLinkageName();
+      report_fatal_error(StrBuf.str());
+    }
     GlobalDeclarationMap[GV] = Var;
   }
 }
 
 void Converter::convertGlobals(Module *Mod) {
   lowerGlobals(LLVM2ICEGlobalsConverter(*this).convertGlobalsToIce(Mod));
 }
 
 void Converter::convertFunctions() {
   const TimerStackIdT StackID = GlobalContext::TSK_Funcs;
   for (const Function &I : *Mod) {
     if (I.empty())
       continue;
 
     TimerIdT TimerID = 0;
     const bool TimeThisFunction = Ctx->getFlags().getTimeEachFunction();
     if (TimeThisFunction) {
       TimerID = Ctx->getTimerID(StackID, I.getName());
       Ctx->pushTimer(TimerID, StackID);
     }
     LLVM2ICEFunctionConverter FunctionConverter(*this);
     FunctionConverter.convertFunction(&I);
     if (TimeThisFunction)
       Ctx->popTimer(TimerID, StackID);
   }
 }
 
 } // end of namespace Ice