Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1095)

Issue 1387933005: [Android] Switch instrumentation tests to platform mode. (Closed)

Created:
5 years, 2 months ago by jbudorick
Modified:
4 years, 10 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Switch instrumentation tests to platform mode. BUG=428729 Committed: https://crrev.com/e5648339683b69d8eba1b7899b4e2593d2f83de0 Cr-Commit-Position: refs/heads/master@{#377324}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix isolate_file_path handling #

Patch Set 4 : fix suite reporting #

Patch Set 5 : isolate chrome/test/data/android/ #

Patch Set 6 : + wrapper script branch #

Patch Set 7 : rebase #

Patch Set 8 : disable the server check #

Patch Set 9 : remove server check from MultiActivityTestBase #

Patch Set 10 : no more --disable-fre #

Patch Set 11 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M build/android/pylib/instrumentation/instrumentation_test_instance.py View 1 2 3 4 5 6 7 8 9 2 chunks +6 lines, -2 lines 0 comments Download
M build/android/pylib/local/device/local_device_instrumentation_test_run.py View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M build/android/test_runner.py View 1 2 3 4 5 6 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
jbudorick
4 years, 10 months ago (2016-02-24 14:37:05 UTC) #2
rnephew (Wrong account)
On 2016/02/24 14:37:05, jbudorick - slow til Feb 25 wrote: lgtm
4 years, 10 months ago (2016-02-24 16:57:50 UTC) #3
rnephew (Reviews Here)
On 2016/02/24 16:57:50, rnephew wrote: > On 2016/02/24 14:37:05, jbudorick - slow til Feb 25 ...
4 years, 10 months ago (2016-02-24 16:58:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1387933005/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1387933005/200001
4 years, 10 months ago (2016-02-24 17:10:14 UTC) #6
commit-bot: I haz the power
Committed patchset #11 (id:200001)
4 years, 10 months ago (2016-02-24 18:43:24 UTC) #7
commit-bot: I haz the power
Patchset 11 (id:??) landed as https://crrev.com/e5648339683b69d8eba1b7899b4e2593d2f83de0 Cr-Commit-Position: refs/heads/master@{#377324}
4 years, 10 months ago (2016-02-24 18:44:33 UTC) #9
jbudorick
A revert of this CL (patchset #11 id:200001) has been created in https://codereview.chromium.org/1738543002/ by jbudorick@chromium.org. ...
4 years, 10 months ago (2016-02-24 22:49:15 UTC) #10
mikecase (-- gone --)
On 2016/02/24 at 22:49:15, jbudorick wrote: > A revert of this CL (patchset #11 id:200001) ...
4 years, 10 months ago (2016-02-25 15:55:03 UTC) #11
jbudorick
4 years, 10 months ago (2016-02-25 16:00:12 UTC) #12
Message was sent while issue was closed.
On 2016/02/25 15:55:03, mikecase wrote:
> On 2016/02/24 at 22:49:15, jbudorick wrote:
> > A revert of this CL (patchset #11 id:200001) has been created in
> https://codereview.chromium.org/1738543002/ by mailto:jbudorick@chromium.org.
> > 
> > The reason for reverting is: CRONET.
> 
> Got some step logcats before this was reverted.
>
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg...

Sweet!

> 
> Will work on uploading them to GS so we don't fill the bots with logs (iirc,
the
> logs don't get
> cleaned up immediately if they aren't uploaded somewhere?)

Yeah, that can happen.

Powered by Google App Engine
This is Rietveld 408576698