base/debug/stack_trace.h - Issue 1387913002: Copy the register context before calling StackWalk64

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/debug/stack_trace.h

Issue 1387913002: Copy the register context before calling StackWalk64 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/debug/stack_trace.h

diff --git a/base/debug/stack_trace.h b/base/debug/stack_trace.h

index 85c91777b49737dd2eb1fbd2fa2d24eaa285d438..d35468fadd2080ad9a5f65486465f9d8830be7fd 100644

--- a/base/debug/stack_trace.h

+++ b/base/debug/stack_trace.h

@@ -52,7 +52,7 @@ class BASE_EXPORT StackTrace {

// Note: this function will throw an import not found (StackWalk64) exception

// on system without dbghelp 5.1.

StackTrace(_EXCEPTION_POINTERS* exception_pointers);

- StackTrace(_CONTEXT* context);

+ StackTrace(const _CONTEXT* context);

#endif

// Copying and assignment are allowed with the default functions.

@@ -76,7 +76,7 @@ class BASE_EXPORT StackTrace {

private:

#if defined(OS_WIN)

- void InitTrace(_CONTEXT* context_record);

+ void InitTrace(const _CONTEXT* context_record);

#endif

// From http://msdn.microsoft.com/en-us/library/bb204633.aspx,

« no previous file with comments | « no previous file | base/debug/stack_trace_win.cc » ('j') | no next file with comments »