Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 13879011: message_center: Convert NotificationCenterButton to LabelButton. (Closed)

Created:
7 years, 8 months ago by tfarina
Modified:
7 years, 8 months ago
Reviewers:
msw, Jun Mukai
CC:
chromium-reviews
Visibility:
Public.

Description

message_center: Convert NotificationCenterButton to LabelButton. BUG=155363 R=msw@chromium.org,mukai@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195401

Patch Set 1 #

Total comments: 8

Patch Set 2 : fix nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -12 lines) Patch
M ui/message_center/views/message_center_view.cc View 1 3 chunks +8 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
7 years, 8 months ago (2013-04-19 22:13:47 UTC) #1
Jun Mukai
lgtm
7 years, 8 months ago (2013-04-19 22:35:58 UTC) #2
msw
LGTM with nits. https://codereview.chromium.org/13879011/diff/1/ui/message_center/views/message_center_view.cc File ui/message_center/views/message_center_view.cc (right): https://codereview.chromium.org/13879011/diff/1/ui/message_center/views/message_center_view.cc#newcode112 ui/message_center/views/message_center_view.cc:112: // Overridden from views::View: nit: // ...
7 years, 8 months ago (2013-04-20 00:08:20 UTC) #3
tfarina
https://codereview.chromium.org/13879011/diff/1/ui/message_center/views/message_center_view.cc File ui/message_center/views/message_center_view.cc (right): https://codereview.chromium.org/13879011/diff/1/ui/message_center/views/message_center_view.cc#newcode112 ui/message_center/views/message_center_view.cc:112: // Overridden from views::View: On 2013/04/20 00:08:20, msw wrote: ...
7 years, 8 months ago (2013-04-20 15:37:16 UTC) #4
tfarina
7 years, 8 months ago (2013-04-20 19:40:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r195401 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698