Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Issue 1387883004: third_party/WebKit: Remove codereview.settings file. (Closed)

Created:
5 years, 2 months ago by tfarina
Modified:
5 years, 2 months ago
Reviewers:
tkent, agable
CC:
agable, asanka, benjhayden+dwatch_chromium.org, blink-reviews, chromium-reviews, Dirk Pranke, jochen (gone - plz use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

third_party/WebKit: Remove codereview.settings file. This way all CLs go through chromium-reviews@chromium.org mailing list instead of going to both blink-reviews and chromium-reviews, which is confusing and annoying for people not subscribed to any of them. https://groups.google.com/a/chromium.org/d/topic/blink-dev/Ae4CTLg2tkw/discussion BUG=None R=tkent@chromium.org Committed: https://crrev.com/d878cd0f66a72eb4096101c17cee20a458718283 Cr-Commit-Position: refs/heads/master@{#352602}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
D third_party/WebKit/codereview.settings View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
agable
LGTM. Would also be a good idea to merge this change into currently active release ...
5 years, 2 months ago (2015-10-05 23:22:07 UTC) #2
tkent
lgtm
5 years, 2 months ago (2015-10-05 23:33:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1387883004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1387883004/1
5 years, 2 months ago (2015-10-06 14:11:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-06 15:04:58 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 15:06:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d878cd0f66a72eb4096101c17cee20a458718283
Cr-Commit-Position: refs/heads/master@{#352602}

Powered by Google App Engine
This is Rietveld 408576698