Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1993)

Unified Diff: bench/nanobench.cpp

Issue 1387863002: Specify bench_type & source_type for image benches (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: "codec" -> "skcodec" Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bench/nanobench.cpp
diff --git a/bench/nanobench.cpp b/bench/nanobench.cpp
index a7a47c52769ce11d8cd0de989f09b3fdae5f0d59..4ab6ca0b88c238aef127c644c3a3ec93e4ade075 100644
--- a/bench/nanobench.cpp
+++ b/bench/nanobench.cpp
@@ -790,8 +790,9 @@ public:
}
}
-
for (; fCurrentCodec < fImages.count(); fCurrentCodec++) {
+ fSourceType = "image";
+ fBenchType = "skcodec";
const SkString& path = fImages[fCurrentCodec];
SkAutoTUnref<SkData> encoded(SkData::NewFromFileName(path.c_str()));
SkAutoTDelete<SkCodec> codec(SkCodec::NewFromData(encoded));
@@ -845,6 +846,8 @@ public:
// Run the DecodingBenches
while (fCurrentImage < fImages.count()) {
+ fSourceType = "image";
+ fBenchType = "skimagedecoder";
while (fCurrentColorType < fColorTypes.count()) {
const SkString& path = fImages[fCurrentImage];
SkColorType colorType = fColorTypes[fCurrentColorType];
@@ -866,6 +869,8 @@ public:
bool useCodecOpts[] = { true, false };
while (fUseCodec < 2) {
bool useCodec = useCodecOpts[fUseCodec];
+ fSourceType = "image";
+ fBenchType = useCodec ? "skcodec" : "skimagedecoder";
while (fCurrentSubsetImage < fImages.count()) {
while (fCurrentColorType < fColorTypes.count()) {
const SkString& path = fImages[fCurrentSubsetImage];
@@ -914,9 +919,12 @@ public:
// Run the BRDBenches
// We will benchmark multiple BRD strategies.
- const SkBitmapRegionDecoderInterface::Strategy strategies[] = {
- SkBitmapRegionDecoderInterface::kOriginal_Strategy,
- SkBitmapRegionDecoderInterface::kCanvas_Strategy,
+ static const struct {
+ SkBitmapRegionDecoderInterface::Strategy fStrategy;
+ const char* fName;
+ } strategies[] = {
+ { SkBitmapRegionDecoderInterface::kOriginal_Strategy, "BRD" },
+ { SkBitmapRegionDecoderInterface::kCanvas_Strategy, "BRD_canvas" },
};
// We intend to create benchmarks that model the use cases in
@@ -937,12 +945,14 @@ public:
const uint32_t minOutputSize = 512;
while (fCurrentBRDImage < fImages.count()) {
while (fCurrentBRDStrategy < (int) SK_ARRAY_COUNT(strategies)) {
+ fSourceType = "image";
+ fBenchType = strategies[fCurrentBRDStrategy].fName;
while (fCurrentColorType < fColorTypes.count()) {
while (fCurrentBRDSampleSize < (int) SK_ARRAY_COUNT(sampleSizes)) {
while (fCurrentSubsetType <= kLastSingle_SubsetType) {
const SkString& path = fImages[fCurrentBRDImage];
const SkBitmapRegionDecoderInterface::Strategy strategy =
- strategies[fCurrentBRDStrategy];
+ strategies[fCurrentBRDStrategy].fStrategy;
SkAutoTUnref<SkData> encoded(SkData::NewFromFileName(path.c_str()));
const SkColorType colorType = fColorTypes[fCurrentColorType];
uint32_t sampleSize = sampleSizes[fCurrentBRDSampleSize];
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698